Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 481762 - [Tracker] keepdir should be an external command
Summary: [Tracker] keepdir should be an external command
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PMS/EAPI
URL: http://dev.gentoo.org/~ulm/pms/5/pms....
Whiteboard:
Keywords: Tracker
Depends on: 482128 482130
Blocks:
  Show dependency tree
 
Reported: 2013-08-20 15:43 UTC by Ulrich Müller
Modified: 2014-02-25 06:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2013-08-20 15:43:35 UTC
keepdir is defined in PMS section 11.3.3.8 "Installation commands" which says:

   These commands must all be external programs and not bash functions or
   aliases—that is, they must be callable from xargs.

All package managers implement keepdir as a shell function, though. Should we fix the spec or the package managers?
Comment 1 Ulrich Müller gentoo-dev 2013-08-22 15:29:08 UTC
CCing PM maintainers.
Comment 2 Ulrich Müller gentoo-dev 2013-08-22 17:45:19 UTC
keepdir doesn't set any variables, so there's no reason for it to be a function. Also an external command is more in line with dodir.

Fixed in Portage, as discussed with zmedico:
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=77570d9d3df177dc2cb55a83541965a32dd79c67

Changing this bug to a tracker; I'm going to file new bugs for the other PMs.
Comment 3 Zac Medico gentoo-dev 2013-09-10 00:41:30 UTC
(In reply to Ulrich Müller from comment #2)
> Fixed in Portage, as discussed with zmedico:
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;
> h=77570d9d3df177dc2cb55a83541965a32dd79c67

This is released in sys-apps/portage-2.2.2.