Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 480928 - net-misc/asterisk-* - improved CNG handling for format_g729
Summary: net-misc/asterisk-* - improved CNG handling for format_g729
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Tony Vroon (RETIRED)
URL: https://issues.asterisk.org/jira/brow...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 21:44 UTC by Jaco Kroon
Modified: 2013-08-28 10:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
asterisk-g729-vad-detection.patch (asterisk_g729_vad_detection.patch,2.68 KB, patch)
2013-08-13 21:56 UTC, Jaco Kroon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2013-08-13 21:44:15 UTC
Tony,

Basically this serves two purposes:

1.  It stops flooding my logs with pointless "" WARNINGS on calls where the peer ignores annexb=no.
2.  It gets small amounts (typically 10-50ms) worth of audio from the broken streams instead of discarding it.

It just makes the broken state of a handful of remote peers easier to deal with for me, as well as to get those small bits of audio before VAD (CNG) kicks in.  I've got an external application that post-Monitor (Not MixMonitor) goes and detects CNG and replaces it with random samples from silence/10.g729 - which seems to work quite well.

Reproducible: Always
Comment 1 Jaco Kroon 2013-08-13 21:56:42 UTC
Created attachment 355904 [details, diff]
asterisk-g729-vad-detection.patch
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2013-08-28 10:11:28 UTC
+*asterisk-11.5.1 (28 Aug 2013)
+*asterisk-1.8.23.1 (28 Aug 2013)
+
+  28 Aug 2013; Tony Vroon <chainsaw@gentoo.org> -asterisk-1.8.22.0.ebuild,
+  -asterisk-1.8.23.0.ebuild, +asterisk-1.8.23.1.ebuild,
+  -asterisk-11.4.0.ebuild, -asterisk-11.5.0.ebuild, +asterisk-11.5.1.ebuild,
+  +files/1.8.0/asterisk.initd7:
+  Security upgrades for AST-2013-004 & AST-2013-005 on both branches.
+  Behavioral improvements for G729 VAD, closes bug #480928. Add missed
+  ownership checks to init script, closes bug #482688. Both by Jaco Kroon.
+  Removed all insecure non-stable ebuilds.