Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 480892 - Allow use of DOCS="" as a way of resetting the PM supplied list (was: =sys-fs/eudev-1.2-r1: In /usr/libexec/paludis/utils/dodoc at line 41 : at least one argument needed)
Summary: Allow use of DOCS="" as a way of resetting the PM supplied list (was: =sys-fs...
Status: RESOLVED DUPLICATE of bug 463736
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PMS/EAPI
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 16:11 UTC by Franz Trischberger
Modified: 2016-05-18 05:20 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (1376407408-install-sys-fs_eudev-1.2-r1:0::gentoo.out,135.28 KB, text/plain)
2013-08-13 16:11 UTC, Franz Trischberger
Details
Patch for multilib-minimal.eclass (multilib-minimal.eclass.diff,375 bytes, patch)
2013-08-20 07:24 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Franz Trischberger 2013-08-13 16:11:25 UTC
Created attachment 355882 [details]
build.log

I tried to install eudev which failed.
Enabling USE="doc" failed with the same error.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2013-08-13 16:14:21 UTC
sys-apps/paludis doesn't have a default list of DOCS to install like sys-apps/portage? i'm asking, not stating.
Comment 2 Franz Trischberger 2013-08-13 16:33:50 UTC
(In reply to Samuli Suominen from comment #1)
> sys-apps/paludis doesn't have a default list of DOCS to install like
> sys-apps/portage? i'm asking, not stating.

I don't know about that. AFAIK it's the first time I hit such an error. But your question seems to imply this might be an issue with paludis.

As I am on the way "back to the roots" (today was moving from systemd back to openrc ;)) I don't know how long I will have paludis running - probably next weekend I am transitioning back to portage, as paludis bit me quite some time in the past weeks and maintenance seems to be sub-par (at best, if there currently is any).
(Just stating this, if a DEV wants to fix this and needs me using paludis)
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-08-13 16:37:51 UTC
If this is because of empty DOCS="", then what is the correct way to tell default_src_install to ignore installation of default list of docs from the PM?

app-dicts/canna-2ch/canna-2ch-20040519.ebuild:DOCS=""
dev-python/icalendar/icalendar-3.2.ebuild:DOCS=""
gnome-base/gvfs/gvfs-1.14.2.ebuild:	DOCS=""
media-fonts/ekushey-bangla-fonts/ekushey-bangla-fonts-20070420.ebuild:DOCS=""
media-fonts/sil-padauk/sil-padauk-2.8.ebuild:DOCS=""
media-fonts/thaifonts-scalable/thaifonts-scalable-0.4.13.ebuild:DOCS=""
media-libs/jpeg/jpeg-6b-r11.ebuild:DOCS=""
media-libs/tiff/tiff-3.9.7-r1.ebuild:DOCS=""
net-irc/hexchat/hexchat-2.9.5.ebuild:DOCS=""
net-irc/hexchat/hexchat-2.9.5_p20130525.ebuild:DOCS=""
net-irc/hexchat/hexchat-2.9.5-r1.ebuild:DOCS=""
net-mail/notmuch/notmuch-0.10.2-r3.ebuild:	DOCS="" bindings python distutils_src_install
net-mail/notmuch/notmuch-0.11.1-r3.ebuild:	DOCS="" bindings python distutils_src_install
net-mail/notmuch/notmuch-0.12.ebuild:	DOCS="" bindings python distutils_src_install
net-mail/notmuch/notmuch-0.13.1.ebuild:	DOCS="" bindings python distutils_src_install
net-mail/notmuch/notmuch-0.14-r1.ebuild:	DOCS="" bindings python distutils_src_install
net-mail/notmuch/notmuch-0.15.2.ebuild:	DOCS="" bindings python distutils_src_install
net-mail/notmuch/notmuch-0.16.ebuild:	DOCS="" bindings python distutils-r1_src_install
sys-fs/eudev/eudev-1.2-r1.ebuild:DOCS=""
sys-fs/eudev/eudev-9999.ebuild:DOCS=""
Comment 4 Ulrich Müller gentoo-dev 2013-08-13 16:46:42 UTC
Paludis is actually compliant with PMS here:
http://dev.gentoo.org/~ulm/pms/5/pms.html#x1-1030009.1.9

Seems the case that empty DOCS could be needed was overlooked when the default src_install was specified for EAPI 4.
Comment 5 Franz Trischberger 2013-08-13 16:52:52 UTC
(In reply to Samuli Suominen from comment #3)
> If this is because of empty DOCS="", then what is the correct way to tell
> default_src_install to ignore installation of default list of docs from the
> PM?
> 
> app-dicts/canna-2ch/canna-2ch-20040519.ebuild:DOCS=""
> dev-python/icalendar/icalendar-3.2.ebuild:DOCS=""
> gnome-base/gvfs/gvfs-1.14.2.ebuild:	DOCS=""
> media-fonts/ekushey-bangla-fonts/ekushey-bangla-fonts-20070420.ebuild:DOCS=""
> media-fonts/sil-padauk/sil-padauk-2.8.ebuild:DOCS=""
> media-fonts/thaifonts-scalable/thaifonts-scalable-0.4.13.ebuild:DOCS=""
> media-libs/jpeg/jpeg-6b-r11.ebuild:DOCS=""
> media-libs/tiff/tiff-3.9.7-r1.ebuild:DOCS=""
> net-irc/hexchat/hexchat-2.9.5.ebuild:DOCS=""
> net-irc/hexchat/hexchat-2.9.5_p20130525.ebuild:DOCS=""
> net-irc/hexchat/hexchat-2.9.5-r1.ebuild:DOCS=""
> net-mail/notmuch/notmuch-0.10.2-r3.ebuild:	DOCS="" bindings python
> distutils_src_install
> net-mail/notmuch/notmuch-0.11.1-r3.ebuild:	DOCS="" bindings python
> distutils_src_install
> net-mail/notmuch/notmuch-0.12.ebuild:	DOCS="" bindings python
> distutils_src_install
> net-mail/notmuch/notmuch-0.13.1.ebuild:	DOCS="" bindings python
> distutils_src_install
> net-mail/notmuch/notmuch-0.14-r1.ebuild:	DOCS="" bindings python
> distutils_src_install
> net-mail/notmuch/notmuch-0.15.2.ebuild:	DOCS="" bindings python
> distutils_src_install
> net-mail/notmuch/notmuch-0.16.ebuild:	DOCS="" bindings python
> distutils-r1_src_install
> sys-fs/eudev/eudev-1.2-r1.ebuild:DOCS=""
> sys-fs/eudev/eudev-9999.ebuild:DOCS=""

I also use notmuch and it installs fine. (Just tested again)
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2013-08-13 16:58:32 UTC
(In reply to Franz Fellner from comment #5)
> I also use notmuch and it installs fine. (Just tested again)

That list might contain false-positives, so that might not proof anything.
Comment 7 Ulrich Müller gentoo-dev 2013-08-13 17:09:53 UTC
Actually, the only packages that don't look like false positives are media-libs/jpeg, media-libs/tiff, and sys-fs/eudev. And these are not using the package manager's default, but multilib-minimal_src_install().
Comment 8 Ian Stakenvicius (RETIRED) gentoo-dev 2013-08-13 17:29:34 UTC
+  13 Aug 2013; Ian Stakenvicius <axs@gentoo.org> eudev-1.2-r1.ebuild,
+  eudev-1.2.ebuild, eudev-9999.ebuild:
+  dropped DOCS='' as it is not PMS-legal (bug 480892) [..]


..to address the failure in eudev, for now.  Once we figure out exactly what multilib-* eclass might be contributing we should reassign the bug.
Comment 9 Franz Trischberger 2013-08-14 08:07:47 UTC
Thanks for the fix, installed just fine :)
Comment 10 Anthony Basile gentoo-dev 2013-08-17 16:17:44 UTC
(In reply to Ian Stakenvicius from comment #8)
> +  13 Aug 2013; Ian Stakenvicius <axs@gentoo.org> eudev-1.2-r1.ebuild,
> +  eudev-1.2.ebuild, eudev-9999.ebuild:
> +  dropped DOCS='' as it is not PMS-legal (bug 480892) [..]
> 
> 
> ..to address the failure in eudev, for now.  Once we figure out exactly what
> multilib-* eclass might be contributing we should reassign the bug.

Ian, did you just forget to close the bug because it looks fixed.
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2013-08-19 13:59:16 UTC
(In reply to Anthony Basile from comment #10)
> (In reply to Ian Stakenvicius from comment #8)
> > +  13 Aug 2013; Ian Stakenvicius <axs@gentoo.org> eudev-1.2-r1.ebuild,
> > +  eudev-1.2.ebuild, eudev-9999.ebuild:
> > +  dropped DOCS='' as it is not PMS-legal (bug 480892) [..]
> > 
> > 
> > ..to address the failure in eudev, for now.  Once we figure out exactly what
> > multilib-* eclass might be contributing we should reassign the bug.
> 
> Ian, did you just forget to close the bug because it looks fixed.

I don't think this is fixed at all, both PMS and the code in multilib-minimal.eclass remain broken as they should be allowing empty DOCS=""
as a way of resetting the PM supplied list.
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2013-08-19 14:02:39 UTC
The code for DOCS handling at the end of multilib-minimal.eclass looks broken too, as it ends up calling dodoc without arguments when it's set but empty? Or am I seeing wrong?
CCing multilib-minimal eclass maintainer hasufell@ as well for that
Comment 13 Julian Ospald 2013-08-19 15:26:22 UTC
(In reply to Samuli Suominen from comment #12)
> The code for DOCS handling at the end of multilib-minimal.eclass looks
> broken too, as it ends up calling dodoc without arguments when it's set but
> empty? Or am I seeing wrong?
> CCing multilib-minimal eclass maintainer hasufell@ as well for that

Please do tests before you call something broken.

Empty DOCS works perfectly with portage.

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob;f=bin/ebuild-helpers/doins;h=4679e83a9a7140e100da733cb34faad384991a64;hb=HEAD#l10
Comment 14 Ulrich Müller gentoo-dev 2013-08-19 16:15:02 UTC
(In reply to Julian Ospald (hasufell) from comment #13)
> Empty DOCS works perfectly with portage.
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob;f=bin/
> ebuild-helpers/doins;h=4679e83a9a7140e100da733cb34faad384991a64;hb=HEAD#l10

Bug 481664 now.
Comment 15 Ulrich Müller gentoo-dev 2013-08-20 07:24:23 UTC
Created attachment 356468 [details, diff]
Patch for multilib-minimal.eclass

I suggest that we proceed as follows:
- Fix multilib-minimal_src_install to allow for empty DOCS, see attached patch.
- Fix the package manager's default_src_install accordingly in EAPI 6
  (see bug 463736).
- Add a QA warning to dodoc if called without arguments, in order to prevent
  further ebuilds from relying on Portage specific behaviour (bug 481664).
- Fix the few (if any) ebuilds that are using the package manager's
  default_src_install with empty DOCS.
Comment 16 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-20 07:42:02 UTC
(In reply to Ulrich Müller from comment #15)
> Created attachment 356468 [details, diff] [details, diff]
> Patch for multilib-minimal.eclass
> 
> I suggest that we proceed as follows:
> - Fix multilib-minimal_src_install to allow for empty DOCS, see attached
> patch.

But what's the point for that? IMO the inconsistency with EAPI behavior is not worth it. You can simple override multilib_src_install_all() since it does nothing more than installing docs AFAIR.
Comment 17 Ulrich Müller gentoo-dev 2013-08-20 07:48:45 UTC
(In reply to Michał Górny from comment #16)
> > - Fix multilib-minimal_src_install to allow for empty DOCS, see attached
> > patch.
> 
> But what's the point for that? IMO the inconsistency with EAPI behavior is
> not worth it. You can simple override multilib_src_install_all() since it
> does nothing more than installing docs AFAIR.

Huh? multilib-minimal_src_install() always processes DOCS, regardless of multilib_src_install_all() being defined or not. So there's no easy way to override the default.
Comment 18 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-20 08:01:35 UTC
Oh my. Hasufell, kiddo, why did you do that? ;f
Comment 19 Julian Ospald 2013-08-20 11:49:19 UTC
(In reply to Michał Górny from comment #18)
> Oh my. Hasufell, kiddo, why did you do that? ;f

WTF? YOU requested it and YOU reviewed it.
Comment 20 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-20 12:39:42 UTC
(In reply to Julian Ospald (hasufell) from comment #19)
> (In reply to Michał Górny from comment #18)
> > Oh my. Hasufell, kiddo, why did you do that? ;f
> 
> WTF? YOU requested it and YOU reviewed it.

Really? I don't recall telling you to do docs outta _all().
Comment 21 Julian Ospald 2013-08-20 12:41:20 UTC
(In reply to Michał Górny from comment #20)
> (In reply to Julian Ospald (hasufell) from comment #19)
> > (In reply to Michał Górny from comment #18)
> > > Oh my. Hasufell, kiddo, why did you do that? ;f
> > 
> > WTF? YOU requested it and YOU reviewed it.
> 
> Really? I don't recall telling you to do docs outta _all().

Then you probably missed that during your review and now blame me for not doing it the way you wanted?
Comment 22 Julian Ospald 2013-08-20 12:43:51 UTC
Anyway, I am open to suggestions and patches and have always been.
Comment 23 Ulrich Müller gentoo-dev 2016-05-18 05:20:24 UTC

*** This bug has been marked as a duplicate of bug 463736 ***