Bug 480386 – sys-devel/distcc USE=avahi - installs conf.d file incompatible with systemd

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Malte Starostik 2013-08-09 16:09:22 UTC]

As noted in #470848, systemd doesn't expand variables in files used as EnvironmentFile, so there needs to be a single assignment to DISTCCD_OPTS.

When built with [avahi], the distcc ebuilds adds this to /etc/conf.d/distccd though:

# Enable zeroconf support in distccd
DISTCCD_OPTS="\${DISTCCD_OPTS} --zeroconf"


Reproducible: Always

Steps to Reproduce:
1. Build distcc with USE=avahi
2. Try to start it with systemctl
3.
Actual Results:  
In addition to the (always required) --allow setting, the --zeroconf option needs to be moved to the main DISTCCD_OPTS assignment

Expected Results:  
The default configuration should require minimal changes (adding --allow), no shuffling around of options.

Portage 2.2.0_alpha196 (default/linux/amd64/13.0/desktop/kde, gcc-4.6.3, glibc-2.15-r3, 3.8.13-gentoo-stellaware x86_64)
=================================================================
System uname: Linux-3.8.13-gentoo-stellaware-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E6750_@_2.66GHz-with-gentoo-2.2
KiB Mem:     6106404 total,   1381228 free
KiB Swap:    8387580 total,   8088268 free
Timestamp of tree: Fri, 09 Aug 2013 13:15:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.2_p45
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.7.5, 3.2.5-r1
dev-util/cmake:           2.8.10.2-r2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.10.3, 1.11.6, 1.12.6
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo bircoph crossdev stellaware sunrise
Installed sets: @cross-arm-elf, @cross-avr
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-11.x skype-4.0.0.7-copyright TeamViewer"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/polkit-1/actions /usr/share/themes/oxygen-gtk/gtk-2.0 /usr/share/themes/oxygen-gtk/gtk-3.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--jobs --load-average=3.0"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs candy clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://de-mirror.org/distro/gentoo/"
LANG="de_DE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j -l3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/mnt/portage/repo/gentoo"
PORTDIR_OVERLAY="/mnt/portage/repo/bircoph /usr/local/portage/crossdev /home/malte/devel/stellaware/systemd-overlay /mnt/portage/repo/sunrise"
USE="X a52 aac aalib acl acpi alsa amd64 amr avahi berkdb bluetooth branding bzip2 cairo calendar caps cdda cdr cli cracklib crypt cups curl cxx dbus declarative device-mapper dga djvu dri dts dv dvb dvd dvdr emboss encode exif fam ffmpeg firefox flac fontconfig fortran gdbm geoip gif gimp git gpm iconv icu inotify ipv6 jack java jpeg jpeg2k kde kerberos kipi lame lcms ldap libnotify libsamplerate lirc lm_sensors lvm lzma mad matroska mikmod mmx mng modules mp3 mp4 mpeg mtp mudflap multilib mysql ncurses nls nptl ogg openal openexr opengl openmp oscar pam pam_krb5 pango pcre pdf perl phonon plasma png policykit postgres ppds python qt3support qt4 quicktime readline samba sasl scanner schroedinger sdl semantic-desktop session smp sndfile snmp speex spell sqlite sse sse2 sse3 ssl startup-notification svg systemd tcpd telepathy theora threads tiff truetype udev udisks unicode upower usb usrmerge v4l vcd vdpau vhosts vim-syntax vorbis vpx webkit wxwidgets x264 xattr xcb xcomposite xine xinerama xml xmp xscreensaver xv xvid xvmc zeroconf zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DRACUT_MODULES="lvm systemd crypt lvm mdraid" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev wacom joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de en" LIRC_DEVICES="devinput" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-4" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby19 ruby18" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON

[Comment 1 Pacho Ramos 2013-08-26 10:03:32 UTC]

I think conf.d usage in service file could be dropped in favor of setting proper defaults and sedding service unit file with --zeroconf option when needed depending on avahi USE flag

[Comment 2 Alexander Tsoy 2013-08-26 13:15:11 UTC]

(In reply to Pacho Ramos from comment #1)
> I think conf.d usage in service file could be dropped in favor of setting
> proper defaults and sedding service unit file with --zeroconf option when
> needed depending on avahi USE flag

+1

I was about to file a bug about dropping an EnvironmentFile.

[Comment 3 Pacho Ramos 2013-09-08 11:36:45 UTC]

Will still need a config file to specify "--allow..." directives:
https://projects.archlinux.org/svntogit/community.git/tree/trunk/distccd.conf.d?h=packages/distcc

[Comment 4 Pacho Ramos 2013-09-21 12:20:58 UTC]

+*distcc-3.1-r9 (21 Sep 2013)
+
+  21 Sep 2013; Pacho Ramos <[e-mail]> +distcc-3.1-r9.ebuild,
+  +files/distccd.service.conf, -distcc-3.1-r8.ebuild, distcc-3.2_rc1.ebuild,
+  files/distccd.service:
+  Stop relying in conf.d file, fix zeroconf handling (#480386 by Malte
+  Starostik)
+