480372 – net-libs/nodejs - add USE=snapshot

Bug 480372 - net-libs/nodejs - add USE=snapshot

Summary: net-libs/nodejs - add USE=snapshot

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Johan Bergström

URL:
Whiteboard:
Keywords:	EBUILD, PATCH

Depends on:
Blocks:

Reported:	2013-08-09 14:00 UTC by Daniel Maxime
Modified:	2013-08-17 09:37 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
ebuild patch to add snapshot use flag on ebuild 0.10.15 (nodejs-0.10.15-snapshot-useflag.patch,623 bytes, patch) 2013-08-09 14:03 UTC, Daniel Maxime	Details \| Diff
full ebuild 0.10.15 with snapshot use flag (nodejs-0.10.15.ebuild,1.77 KB, text/plain) 2013-08-09 14:04 UTC, Daniel Maxime	Details
ebuild patch to add snapshot use flag on ebuild 0.10.15 (fixed) (nodejs.patch,579 bytes, patch) 2013-08-11 14:19 UTC, Daniel Maxime	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Maxime 2013-08-09 14:00:22 UTC

During compile time, nodejs compiles a "snapshot bin" to continue the build process. During cross-compiling, the bin cannot be run. This patch/ebuild add snapshot USE flags to enable/disable on configure time.

Reproducible: Always

Comment 1 Daniel Maxime 2013-08-09 14:03:45 UTC

Created attachment 355488 [details, diff]
ebuild patch to add snapshot use flag on ebuild 0.10.15

Comment 2 Daniel Maxime 2013-08-09 14:04:33 UTC

Created attachment 355492 [details]
full ebuild 0.10.15 with snapshot use flag

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2013-08-11 12:22:36 UTC

Comment on attachment 355492 [details]
full ebuild 0.10.15 with snapshot use flag

--- nodejs-0.10.15.ebuild       2013-08-01 06:21:25.000000000 +0200
+++ -   2013-08-11 14:22:21.566761956 +0200
@@ -18,7 +18,7 @@
 LICENSE="Apache-1.1 Apache-2.0 BSD BSD-2 MIT"
 SLOT="0"
 KEYWORDS="~amd64 ~arm ~x86 ~x64-macos"
-IUSE="+npm"
+IUSE="+npm +snapshot"
 
 RDEPEND="dev-libs/openssl"
 DEPEND="${RDEPEND}
@@ -41,6 +41,7 @@
 src_configure() {
        local myconf=""
        ! use npm && myconf="--without-npm"
+       ! use snapshot && myconf="--without-snapshot"
 
        "${PYTHON}" configure --prefix="${EPREFIX}"/usr \
                --openssl-use-sys --shared-zlib --without-dtrace ${myconf} || die

Comment 4 Johan Bergström 2013-08-11 12:32:33 UTC

LGTM. Only possible feedback would be if there's a better way of figuring out that we're cross-compiling other than a USE flag?

Comment 5 Daniel Maxime 2013-08-11 14:16:48 UTC

The --without-snapshot flag is not only a cross-compilation option.
The "snapshot" feature speed up the node.js boot time, it's a feature you could be disable if you want.

Comment 6 Daniel Maxime 2013-08-11 14:19:34 UTC

Created attachment 355686 [details, diff]
ebuild patch to add snapshot use flag on ebuild 0.10.15 (fixed)

fixed patch, the snapshot set override previous option (bug when use -npm with -snapshot)

Comment 7 Patrick Lauer gentoo-dev

2013-08-17 09:37:10 UTC

+  17 Aug 2013; Patrick Lauer <patrick@gentoo.org> +nodejs-0.10.16-r1.ebuild,
+  -nodejs-0.10.16.ebuild, metadata.xml:
+  Add snapshot useflag for #480372