First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 47853
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Andrej Kacian (RETIRED) <ticho@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
filelight-0.6.4.1-r1.ebuild A modified ebuild file for filelight text/plain Andrej Kacian (RETIRED) 2004-04-14 15:52 0000 694 bytes Details
filelight-0.6.4.1-r1.ebuild A modified ebuild for filelight text/plain Andrej Kacian (RETIRED) 2004-04-14 17:36 0000 583 bytes Details
filelight-0.6.4.1-r1.ebuild A fixed ebuild for filelight 0.6.4.1 text/plain Andrej Kacian (RETIRED) 2004-04-16 10:31 0000 566 bytes Details
filelight-0.6.4.1-r1.ebuild An ebuild file for filelight 0.6.4-1 text/plain Andrej Kacian (RETIRED) 2004-04-17 10:15 0000 544 bytes Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 47853 depends on: Show dependency tree
Show dependency graph
Bug 47853 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2004-04-14 15:52 0000
The configure script for filelight supports --without-arts option, but the
ebuild doesn't. See attached ebuild, which remedies this problem.

I am not sure if this is the right way:
This ebuild inherits kde-base, so it has kde_src_compile() already. I've
written a replacement src_compile() function which takes "arts" USE flag into
account. Is there any way to re-use the original kde_src_compile() and honor
mentioned USE flag at once?

------- Comment #1 From Andrej Kacian (RETIRED) 2004-04-14 15:52:53 0000 -------
Created an attachment (id=29291) [edit]
A modified ebuild file for filelight

------- Comment #2 From Carsten Lohrke 2004-04-14 17:02:56 0000 -------
- kde-base is deprecated, use kde instead
- the ebuild header is invalid:
http://www.gentoo.org/doc/en/ebuild-mistakes.xml

------- Comment #3 From Andrej Kacian (RETIRED) 2004-04-14 17:36:54 0000 -------
Created an attachment (id=29296) [edit]
A modified ebuild for filelight

Sorry about the header, I just copied and modified the existing ebuild.

I forgot to add that filielight works perfectly even when not using *_compile()
function from kde.eclass.

------- Comment #4 From Carsten Lohrke 2004-04-15 02:44:26 0000 -------
> I forgot to add that filielight works perfectly even when not using *_compile()
function from kde.eclass.

Oh, overlooked that. It will fail because of sandbox problems, when having
userpriv in features. Please replace the econf/emake lines with
"kde_src_compile all". Also the eclass sets a lot of other options, so it isn't
acceptable not to use the inherited function, when inheriting the kde.eclass.

------- Comment #5 From Andrej Kacian (RETIRED) 2004-04-15 08:31:17 0000 -------
That's what I've been asking in my original comment for this bug - how to honor
"arts" USE flag and use functions from kde.eclass at the same time?

------- Comment #6 From Carsten Lohrke 2004-04-15 11:01:39 0000 -------
Just set myconf as you like and call "kde_src_compile all" afterwards. The
function appends a few other options, but doesn't overwrite myconf.

------- Comment #7 From Andrej Kacian (RETIRED) 2004-04-16 10:31:09 0000 -------
Created an attachment (id=29431) [edit]
A fixed ebuild for filelight 0.6.4.1

Thanks for the advice, I now know how to re-use inherited functions :)

------- Comment #8 From Andrej Kacian (RETIRED) 2004-04-17 09:03:19 0000 -------
I forgot to write, that I have included an usable (hopefully) version of
ebuild.

------- Comment #9 From Carsten Lohrke 2004-04-17 09:40:39 0000 -------
A few annotations Andrej: 
- just remove the '&& myconf="${myconf}"' part
- the devs probably wouldn't consider this a -r1, but a silent ebuild update (i could be wrong, though)
- don't lose patience, sometimes these minor ebuild fixes need a while until they get commited

------- Comment #10 From Andrej Kacian (RETIRED) 2004-04-17 10:15:11 0000 -------
Created an attachment (id=29506) [edit]
An ebuild file for filelight 0.6.4-1

Thanks for suggestions, I've fixed the ebuild according to the first one. Let
devs express their opinion about the ebuild name.

------- Comment #11 From Donovan Long 2004-05-18 21:23:06 0000 -------
A great program, very handy.  Apr 17th ebuild works perfectly, ready for
portage?

------- Comment #12 From Andrej Kacian (RETIRED) 2004-05-20 11:16:50 0000 -------
Yes, pretty ready, I think. We've straightened out all quirks by now.

------- Comment #13 From Caleb Tennis 2004-05-25 17:03:14 0000 -------
committed - thanks for ebuild.

First Last Prev Next    No search results available      Search page      Enter new bug