478396 – >=net-p2p/transmission-2.81 USE=gtk with =dev-libs/glib-2.32.4-r1 - tr-icon.c:24:26: error: expected ')' before '-' token

Bug 478396 - >=net-p2p/transmission-2.81 USE=gtk with =dev-libs/glib-2.32.4-r1 - tr-icon.c:24:26: error: expected ')' before '-' token

Summary: >=net-p2p/transmission-2.81 USE=gtk with =dev-libs/glib-2.32.4-r1 - tr-icon.c...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Samuli Suominen (RETIRED)

URL:	https://forum.transmissionbt.com/view...
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2013-07-27 20:57 UTC by Michael
Modified:	2013-08-07 11:40 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build.log (build.log,185.42 KB, text/x-log) 2013-07-27 21:01 UTC, Michael	Details
proposed patch (fix-build-with-old-glib.patch,930 bytes, patch) 2013-07-27 21:02 UTC, Michael	Details \| Diff
build.log (build.log,20.52 KB, text/x-log) 2013-07-29 05:47 UTC, Szymluk	Details
'official' patch (changeset_14142.diff,2.21 KB, patch) 2013-07-31 19:02 UTC, Michael	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael 2013-07-27 20:57:51 UTC

Transmission GTK frontend fails to build with old version of glib. As pointed out here:
https://forum.transmissionbt.com/viewtopic.php?f=2&p=65550

Proposed patch works fine for me.

Reproducible: Always

Comment 1 Michael 2013-07-27 21:01:20 UTC

Created attachment 354334 [details]
Build.log

Comment 2 Michael 2013-07-27 21:02:36 UTC

Created attachment 354336 [details, diff]
proposed patch

Comment 3 Szymluk 2013-07-29 05:45:37 UTC

(In reply to Michael from comment #0)
> Transmission GTK frontend fails to build with old version of glib. As
> pointed out here:
> https://forum.transmissionbt.com/viewtopic.php?f=2&p=65550
> 
> Proposed patch works fine for me.
> 
> Reproducible: Always

I've got similar problem.

Comment 4 Szymluk 2013-07-29 05:47:03 UTC

Created attachment 354484 [details]
build.log

build.log

Comment 5 Samuli Suominen (RETIRED) gentoo-dev

2013-07-31 14:53:41 UTC

i've raised the glib dep.   if you have a link to a patch they applied to their repository, at https://trac.transmissionbt.com/log/trunk/gtk/tr-core.h?rev=14152
we could grab it from there, but I don't see anything changed recently and I'm not comfortable with the unofficial patch.

Comment 6 Michael 2013-07-31 15:15:08 UTC

(In reply to Samuli Suominen from comment #5)
> i've raised the glib dep.   if you have a link to a patch they applied to
> their repository, at
> https://trac.transmissionbt.com/log/trunk/gtk/tr-core.h?rev=14152
> we could grab it from there, but I don't see anything changed recently and
> I'm not comfortable with the unofficial patch.

I believe this is what we are looking for:
https://trac.transmissionbt.com/changeset/14142/

Comment 7 Michael 2013-07-31 18:12:12 UTC

Reopen to add official patch.

Comment 8 Michael 2013-07-31 19:02:12 UTC

Created attachment 354754 [details, diff]
'official' patch

Comment 9 Samuli Suominen (RETIRED) gentoo-dev

2013-08-07 11:38:47 UTC

(In reply to Michael from comment #8)
> Created attachment 354754 [details, diff] [details, diff]
> 'official' patch

Doesn't apply to 2.81 release

Comment 10 Samuli Suominen (RETIRED) gentoo-dev

2013-08-07 11:40:56 UTC

I'm sorry but I won't apply unofficial patch, or go through the effort of backporting the patch by hand
Simple upgrade to more recent glib seems fine enough to me as both are in ~arch