Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478222 - media-video/smplayer2-0.8.0_p20130111 should depend on dev-qt/qtdbus
Summary: media-video/smplayer2-0.8.0_p20130111 should depend on dev-qt/qtdbus
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nikoli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 484196
  Show dependency tree
 
Reported: 2013-07-26 10:42 UTC by Amadeusz Żołnowski (RETIRED)
Modified: 2013-09-08 08:05 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,5.85 KB, application/x-info)
2013-07-26 10:43 UTC, Amadeusz Żołnowski (RETIRED)
Details
build.log (smplayer2-0.8.0_p20130111_build.log,4.05 KB, text/plain)
2013-07-26 10:43 UTC, Amadeusz Żołnowski (RETIRED)
Details
patch (dbus.patch,424 bytes, patch)
2013-07-28 21:46 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Żołnowski (RETIRED) gentoo-dev 2013-07-26 10:42:55 UTC
It seems smplayer2 is missing qtdbus dependency. It was removed by emerge --depclean, because qtgui seems to no longer depend on it.

Reproducible: Always
Comment 1 Amadeusz Żołnowski (RETIRED) gentoo-dev 2013-07-26 10:43:18 UTC
Created attachment 354236 [details]
emerge --info
Comment 2 Amadeusz Żołnowski (RETIRED) gentoo-dev 2013-07-26 10:43:35 UTC
Created attachment 354238 [details]
build.log
Comment 3 Nikoli 2013-07-28 20:32:07 UTC
Seems like this commit was wrong:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/smplayer2/smplayer2-0.8.0_p20130111.ebuild?r1=1.3&r2=1.4

Qt team, please explain why qtdbus dep was removed from qtgui[dbus]? Seems like in a lot packages qtgui dep was changed to not block qtgui-4.8.5, bit qtdbus dep was not added and is missing now.
Comment 4 Davide Pesavento (RETIRED) gentoo-dev 2013-07-28 20:54:22 UTC
(In reply to Nikoli from comment #3)
> Seems like this commit was wrong:
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/
> smplayer2/smplayer2-0.8.0_p20130111.ebuild?r1=1.3&r2=1.4
> 

Yes that commit is wrong. I've already told patrick (CC'ed) to fix this mess, but apparently he hasn't done so yet.

> Qt team, please explain why qtdbus dep was removed from qtgui[dbus]? Seems
> like in a lot packages qtgui dep was changed to not block qtgui-4.8.5, bit
> qtdbus dep was not added and is missing now.

qtgui doesn't require qtdbus, that's why the dep has been removed. The only reason why qtgui used to have a dbus USE flag is that qdbusviewer used to be built in qtgui, and the flag just enabled/disabled that. qdbusviewer has been moved into a separate package for 4.8.5, therefore the flag made no sense anymore and was removed.

Note that the fact that qtgui used to pull in qtdbus was purely an "implementation detail". You should *never* rely on transitive dependencies. If your package requires qtdbus, add qtdbus as an explicit dep, period. Technically speaking, smplayer deps were already broken.

Anyway, the semantically-equivalent replacement for "dev-qt/qtgui[dbus]" is "dev-qt/qdbusviewer dev-qt/qtgui".
However I don't think that *any* packages actually need qdbusviewer, the original intention was probably to pull in qtdbus, therefore I think the correct replacement is "dev-qt/qtdbus dev-qt/qtgui".
Comment 5 Nikoli 2013-07-28 21:46:42 UTC
Created attachment 354456 [details, diff]
patch

Please apply attached patch to every smplayer2 ebuild with USE dbus.

P.S. I expected USE dbus to change something in libQtGui.so, but never checked it.
Comment 6 Sergey Popov gentoo-dev 2013-07-29 08:30:09 UTC
+  29 Jul 2013; Sergey Popov <pinkbyte@gentoo.org>
+  smplayer2-0.7.3_p20120524.ebuild, smplayer2-0.8.0_p20121214.ebuild,
+  smplayer2-0.8.0_p20130111.ebuild, smplayer2-9999.ebuild:
+  Add proper dependency on dev-qt/qtdbus, wrt bug #478222