Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478218 - x11-wm/awesome's awesome-gnome.session needs updating for >=gnome-base/gnome-session-3.8
Summary: x11-wm/awesome's awesome-gnome.session needs updating for >=gnome-base/gnome-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Maxim Koltsov (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-07-26 09:20 UTC by Marien Zwart (RETIRED)
Modified: 2013-10-27 19:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
awesome-gnome.session.patch (awesome-gnome.session.patch,491 bytes, patch)
2013-07-29 18:13 UTC, Alexander Tsoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marien Zwart (RETIRED) gentoo-dev 2013-07-26 09:20:47 UTC
I don't know the protocol for filing bugs against a proxy-maintained package. Please correct the assignee/CC list if I messed that up.

gnome-session 3.8 no longer supports RequiredProviders, see https://bugzilla.gnome.org/show_bug.cgi?id=691663. Non-GNOME sessions are expected to use RequiredComponents instead. This means the awesome-gnome.session no longer starts awesome, just gnome-settings-daemon. This makes it considerably less awesome.

Moving awesome-gnome (and notification-daemon, if still considered necessary) to RequiredComponents should make gnome 3.8 awesome again.
Comment 1 Alexander Tsoy 2013-07-29 18:13:28 UTC
Created attachment 354546 [details, diff]
awesome-gnome.session.patch
Comment 2 Maxim Koltsov (RETIRED) gentoo-dev 2013-07-29 18:38:16 UTC
(In reply to Alexander Tsoy from comment #1)
> Created attachment 354546 [details, diff] [details, diff]
> awesome-gnome.session.patch

Will this patch work with old gnomes too?
Comment 3 Alexander Tsoy 2013-07-29 18:42:53 UTC
(In reply to Maxim Koltsov from comment #2)
> Will this patch work with old gnomes too?

Hard to say. I tested it only with gnome-3.8.
Comment 4 Marien Zwart (RETIRED) gentoo-dev 2013-07-31 09:52:27 UTC
I'd be surprised if this didn't work on older gnomes. RequiredComponents was already used to start gnome-settings-daemon (and you'd probably notice if that wasn't running). Unless older gnomes don't support starting more than one thing that way this should be fine.
Comment 5 Nikolaj Šujskij 2013-08-10 16:06:53 UTC
We should test this patch against at least gnome 2.32 before applying, I'd say.
Comment 6 Pacho Ramos gentoo-dev 2013-08-27 13:00:51 UTC
(In reply to Nikolaj Sjujskij from comment #5)
> We should test this patch against at least gnome 2.32 before applying, I'd
> say.

You could apply the patch in a revbump that would be stabilized with Gnome 3.8
Comment 7 Nikolaj Šujskij 2013-08-28 16:44:12 UTC
(In reply to Pacho Ramos from comment #6)
> (In reply to Nikolaj Sjujskij from comment #5)
> > We should test this patch against at least gnome 2.32 before applying, I'd
> > say.
> 
> You could apply the patch in a revbump that would be stabilized with Gnome
> 3.8

True enough.

Maxim, could you do that pretty please? I'd keep two copies of awesome-gnome.session in ./files/. Then we could ask AT with Gnome 2 to try it out.
Comment 8 Maxim Koltsov (RETIRED) gentoo-dev 2013-10-27 19:11:05 UTC
Patch commited to tree in awesome-3.5.2-r1