Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478128 - app-misc/anki should not auto upgrade
Summary: app-misc/anki should not auto upgrade
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Kahle (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-07-25 12:41 UTC by Yichao Zhou
Modified: 2013-11-05 14:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the anki-2.0.12 ebuild which changes a different autoupdate setting (anki-supress-updates.patch,371 bytes, patch)
2013-11-05 08:27 UTC, Nuno Silva
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yichao Zhou 2013-07-25 12:41:43 UTC
Now anki will prompts for upgradation.  It's annoying!

There is a patch to disable it.  See
https://bugzilla.redhat.com/show_bug.cgi?id=869440


Reproducible: Always
Comment 1 Thomas Kahle (RETIRED) gentoo-dev 2013-07-25 13:01:54 UTC
Should be fixed in 2.0.12.  Thanks!
Comment 2 Yichao Zhou 2013-07-26 06:24:59 UTC
Should this patch be introduced in stable arch?
Comment 3 Thomas Kahle (RETIRED) gentoo-dev 2013-07-26 06:30:11 UTC
(In reply to Yichao Zhou from comment #2)
> Should this patch be introduced in stable arch?

There is a waiting period of 30 days usually for new patches.  In this case it's relatively simple patch.  I'll push for stabilization of a new version of Anki in mid August.
Comment 4 Yichao Zhou 2013-11-03 04:20:08 UTC
Hello, today my anki-2.0.12 prompts for upgrade again.  Not fixed?
Comment 5 Thomas Kahle (RETIRED) gentoo-dev 2013-11-03 19:07:56 UTC
Yes, I also noticed this.  We are setting suppressUpdate=True in aqt/profiles.py, which is supposed to suppress the update warnings, but it does not.  Unfortunately this seems not to work and there is no documentation of the code.  Can you inquire upstream?
Comment 6 Nuno Silva 2013-11-05 08:27:53 UTC
Created attachment 362605 [details, diff]
patch for the anki-2.0.12 ebuild which changes a different autoupdate setting

There are two settings, updates and suppressUpdates.

Reading the anki-2.0.12 code, it seems that suppressUpdates is intended to be a version number which should be ignored when checking for updates. In fact, by analyzing ~/Anki/prefs.db, it seems to be used to keep track of the update I just refused.

'updates', on the other hand, is used in aqt/update.py on line 47 to terminate LatestVersionFinder before any other checks.

Modifying the ebuild to change 'updates' instead of 'suppressUpdates' (see attachment) seems to disable updates here (please note that you may need to get rid of your anki settings (~/Anki) in order to test whether the autoupdater is still triggered).
Comment 7 Thomas Kahle (RETIRED) gentoo-dev 2013-11-05 14:51:03 UTC
Ok, let's run with this.  Thanks for your analysis.  Also note that prefs.db is an sqlite db which you can examine and change on the commandline.  No need to delete all your decks.

+++ ./ChangeLog
@@ -4,0 +5,5 @@
+  05 Nov 2013; Thomas Kahle <tomka@gentoo.org> anki-2.0.12.ebuild,
+  anki-2.0.16.ebuild:
+  Fix bug 478128 (don't mention non-distro upgrades) again. Thanks Nuno J.
+  Silva.