These are unrequired and shouldn't be installed anymore with app-admin/eselect wrt bug 472938 >=app-shells/bash-completion-2.1-r1 will install, and use everything by default with possibility of opt-out by upstream methods of, for example, "complete -r udisksctl" in ~/.bashrc would stop udisksctl from completion However if you want to keep on supporting somekind of bashcomp eselect module, that'd be fine by me too null ssuominen # qfile -b bashcomp-config app-admin/eselect (/usr/bin/bashcomp-config) null ssuominen # qfile -b bashcomp.eselect app-admin/eselect (/usr/share/eselect/modules/bashcomp.eselect)
The only use for eselect module would be simple on/off switch like, 'enable' setting -> source /usr/share/bash-completion/bash_completion 'disable' setting -> don't source /usr/share/bash-completion/bash_completion I'll revision bump eselect tomorrow'ish and punt the files unless someone handles this first (like the real maintainers of eselect :-) Thanks!
Already done a month ago, in the "bashcomp" branch: http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=shortlog;h=refs/heads/bashcomp Please review.
And please review if eselect's method to install eselect.bashcomp is still correct with the new bash-completion: newbashcomp misc/eselect.bashcomp eselect
(In reply to Ulrich Müller from comment #2) > Already done a month ago, in the "bashcomp" branch: > http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=shortlog;h=refs/ > heads/bashcomp > > Please review. (In reply to Ulrich Müller from comment #3) > And please review if eselect's method to install eselect.bashcomp is still > correct with the new bash-completion: > > newbashcomp misc/eselect.bashcomp eselect both looks correct to me /usr/share/bash-completion/completions is used as a default. as in, when there is no installed version of bash-completion at all yet, or when the new version >= 2.1-r1 is installed (by eclass) $ qfile -b -v eselect app-admin/eselect-1.3.6 (/usr/share/bash-completion/completions/eselect)
Rebased and merged to master: http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=commit;h=2ea27fd3794db4758c2f76117f34d6205652ce2b This doesn't imply that I like the direction this is going: You're replacing useful and well-tested functionality by something that is much more primitive.
Fixed in eselect-1.3.7.
All versions of app-shells/bash-completion depend on the eselect module again. Should I undo deletion of bashcomp.eselect in the eselect git repo?
Created attachment 383496 [details] Initial attempt at new bashcomp module It uses /etc/bash/completions.blacklist file to disable completions. Patch to autoloader will follow. We may also want to extend this to support per-user blacklists. However, I think that we should default to '--global' when run by root.
Created attachment 383498 [details, diff] Patch to /usr/share/bash-completion/bash_completion
Created attachment 383506 [details, diff] Updated /usr/share/bash-completion/bash_completion patch This one is updated to support per-user switching.
Created attachment 383508 [details] eselect module w/ user switching support
I'm handling this as part of the revbump :). *** This bug has been marked as a duplicate of bug 472938 ***