Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 476930 - app-office/scribus-1.4.2-r3: imaging and tk are optional, better cmake-utils and python-r1 usage
Summary: app-office/scribus-1.4.2-r3: imaging and tk are optional, better cmake-utils ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-15 15:19 UTC by Nikoli
Modified: 2013-08-31 17:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for ebuild (scribus-1.4.2-r3.ebuild.patch,2.20 KB, patch)
2013-07-15 15:19 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2013-07-15 15:19:59 UTC
Created attachment 353352 [details, diff]
patch for ebuild

Please commit attached patch. According to file BUILDING from tar and to http://wiki.scribus.net/canvas/Official:Compilation_Requirements imaging and tk are optional. They are used only in 4 python scripts. scribus is Qt app, i do not have tk in my systems and do not want to install it.

Also fixed other small problems of ebuild:
python-r1 eclasses have python_get_library_path, it safer to put such paths into quotes in case if EPREFIX has spaces, multilib.eclass is not used after this change.
using 'use examples || mycmakeargs+=( -DWANT_NOEXAMPLES=ON)' seems wrong, better use '$(cmake-utils_use_want !examples NOEXAMPLES)'

P.S. Also you may want to use l10n.eclass.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2013-08-07 20:26:04 UTC
+*scribus-1.4.3 (07 Aug 2013)
+
+  07 Aug 2013; Justin Lecher <jlec@gentoo.org> +scribus-1.4.3.ebuild,
+  metadata.xml:
+  Version BUmp, #479782; fix build against cairo; enhance cmake-utils.eclass
+  and python-r1.eclass usage, #476930; make scripts optional, #476930
+
Comment 2 Nikoli 2013-08-31 17:42:33 UTC
There is pointless line in DEPEND:
tk? ( virtual/python-imaging[tk?,${PYTHON_USEDEP}] )

DEPEND has 'scripts? ( virtual/python-imaging[tk?,${PYTHON_USEDEP}] )' line and REQUIRED_USE has 'tk? ( scripts )' line.