Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 476598 - media-video/vlc - Remove USE aac and disable faad
Summary: media-video/vlc - Remove USE aac and disable faad
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tom Wijsman (TomWij) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-12 00:05 UTC by Nikoli
Modified: 2013-10-26 08:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2013-07-12 00:05:02 UTC
faad is not updated since 2009 year, please disable it in vlc ebuilds and remove USE aac. By default vlc uses libavcodec from ffmpeg or libav for aac decoding, faad is disabled by default in configure script:
$ sh ./configure --help|grep faad
  --enable-faad           faad codec (default disabled)
  --with-faad-tree=PATH   faad tree for static linking

When USE aac is enabled, vlc will not use libavcodec for aac decoding, but will use faad.
USE="aac":
$ vlc -v -v -v video.mkv|grep -e decoder
[0x340a4c18da8] main decoder debug: looking for decoder module: 31 candidates
[0x340a4c18da8] avcodec decoder debug: libavcodec initialized (interface 0x362300)
[0x340a4c18da8] avcodec decoder debug: trying to use direct rendering
[0x340a4c18da8] avcodec decoder debug: allowing 4 thread(s) for decoding
[0x340a4c18da8] avcodec decoder debug: ffmpeg codec (H264 - MPEG-4 AVC (part 10)) started
[0x340a4c18da8] avcodec decoder debug: using frame thread mode with 4 threads
[0x340a4c18da8] main decoder debug: using decoder module "avcodec"
[0x340a4c18da8] main decoder debug: TIMER module_need() : 8.607 ms - Total 8.607 ms / 1 intvls (Avg 8.607 ms)
[0x340a4c05fd8] main decoder debug: looking for decoder module: 31 candidates
[0x340a4c05fd8] main decoder debug: using decoder module "faad"
[0x340a4c05fd8] main decoder debug: TIMER module_need() : 0.159 ms - Total 0.159 ms / 1 intvls (Avg 0.159 ms)
[0x340a4c071f8] main decoder debug: looking for decoder module: 31 candidates
[0x340a4c071f8] main decoder debug: using decoder module "spudec"
[0x340a4c071f8] main decoder debug: TIMER module_need() : 0.102 ms - Total 0.102 ms / 1 intvls (Avg 0.102 ms)
[0x340a4c071f8] spudec decoder debug: invalid starting packet (size < 4 or pts <=0)
[0x340a4c071f8] spudec decoder debug: spu size: 0, i_pts: 0 i_buffer: 128
[0x340a4c05fd8] faad decoder warning: decoded zero sample
[0x340a4c18da8] avcodec decoder debug: using direct rendering
[0x340a4c05fd8] main decoder debug: End of audio preroll
[0x340a4c18da8] main decoder debug: End of video preroll
[0x340a4c18da8] main decoder debug: removing module "avcodec"
[0x340a4c18da8] avcodec decoder debug: ffmpeg codec (H264 - MPEG-4 AVC (part 10)) stopped
[0x340a4c18da8] main decoder debug: killing decoder fourcc `h264', 0 PES in FIFO
[0x340a4c05fd8] main decoder debug: removing module "faad"
[0x340a4c05fd8] main decoder debug: killing decoder fourcc `mp4a', 37 PES in FIFO
[0x340a4c071f8] main decoder debug: removing module "spudec"
[0x340a4c071f8] main decoder debug: killing decoder fourcc `spu ', 0 PES in FIFO

USE="-aac":
$ vlc -v -v -v video.mkv|grep -e decoder
[0x2d820c18d98] main decoder debug: looking for decoder module: 30 candidates
[0x2d820c18d98] avcodec decoder debug: libavcodec initialized (interface 0x362300)
[0x2d820c18d98] avcodec decoder debug: trying to use direct rendering
[0x2d820c18d98] avcodec decoder debug: allowing 4 thread(s) for decoding
[0x2d820c18d98] avcodec decoder debug: ffmpeg codec (H264 - MPEG-4 AVC (part 10)) started
[0x2d820c18d98] avcodec decoder debug: using frame thread mode with 4 threads
[0x2d820c18d98] main decoder debug: using decoder module "avcodec"
[0x2d820c18d98] main decoder debug: TIMER module_need() : 7.501 ms - Total 7.501 ms / 1 intvls (Avg 7.501 ms)
[0x2d820c05fd8] main decoder debug: looking for decoder module: 30 candidates
[0x2d820c05fd8] avcodec decoder debug: libavcodec already initialized
[0x2d820c05fd8] avcodec decoder debug: ffmpeg codec (MPEG AAC Audio) started
[0x2d820c05fd8] avcodec decoder debug: Using 384000 bytes output buffer
[0x2d820c05fd8] main decoder debug: using decoder module "avcodec"
[0x2d820c05fd8] main decoder debug: TIMER module_need() : 2.072 ms - Total 2.072 ms / 1 intvls (Avg 2.072 ms)
[0x2d820c48a98] main decoder debug: looking for decoder module: 30 candidates
[0x2d820c48a98] main decoder debug: using decoder module "spudec"
[0x2d820c48a98] main decoder debug: TIMER module_need() : 0.121 ms - Total 0.121 ms / 1 intvls (Avg 0.121 ms)
[0x2d820c48a98] spudec decoder debug: invalid starting packet (size < 4 or pts <=0)
[0x2d820c48a98] spudec decoder debug: spu size: 0, i_pts: 0 i_buffer: 128
[0x2d820c05fd8] main decoder debug: End of audio preroll
[0x2d820c18d98] avcodec decoder debug: using direct rendering
[0x2d820c18d98] main decoder debug: End of video preroll
[0x2d820c18d98] main decoder debug: removing module "avcodec"
[0x2d820c18d98] avcodec decoder debug: ffmpeg codec (H264 - MPEG-4 AVC (part 10)) stopped
[0x2d820c18d98] main decoder debug: killing decoder fourcc `h264', 0 PES in FIFO
[0x2d820c05fd8] main decoder debug: removing module "avcodec"
[0x2d820c05fd8] avcodec decoder debug: ffmpeg codec (MPEG AAC Audio) stopped
[0x2d820c05fd8] main decoder debug: killing decoder fourcc `mp4a', 36 PES in FIFO
[0x2d820c48a98] main decoder debug: removing module "spudec"
[0x2d820c48a98] main decoder debug: killing decoder fourcc `spu ', 0 PES in FIFO
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-26 08:26:23 UTC
I have renamed it to faad to differentiate it from aac; as long as it works and/or is supported, I don't mind keeping it around.

+  26 Oct 2013; Tom Wijsman <TomWij@gentoo.org> metadata.xml,
+  vlc-2.0.9999.ebuild, vlc-2.1.9999.ebuild, vlc-9999.ebuild:
+  Renamed the aac USE flag to faad as with --disable-faad, libavcodec will do
+  aac decoding; documented the faad USE flag in metadata.xml; solution for bug
+  #476598, reported by Nikoli.

It will be part of today's version bumps.