Bug 476064 – =dev-util/cmake-2.8.10.2-r2 - Patch file cmake-2.8.10.2-FindPythonLibs.patch is not compatible with some versions of sys-devel/patch in the Portage tree.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Helmut Auer 2013-07-07 09:16:15 UTC]

Hello
The file
dev-util/cmake/files/cmake-2.8.10.2-FindPythonLibs.patch
is in DOS Format so the cmake ebuild fails with:

* Applying cmake-2.8.10.2-FindPythonLibs.patch ...
* Failed Patch: cmake-2.8.10.2-FindPythonLibs.patch !
*  ( /mnt/data/portage/dev-util/cmake/files/cmake-2.8.10.2-FindPythonLibs.patch )
*

Reproducible: Always

Steps to Reproduce:
1. emerge cmake-2.8.10.2-r2.ebuild
or just look at
dev-util/cmake/files/cmake-2.8.10.2-FindPythonLibs.patch

[Comment 1 Jeroen Roovers (RETIRED) 2013-07-07 13:35:07 UTC]

It's absolutely fine here, so re-sync your portage tree and try again.

[Comment 2 Helmut Auer 2013-07-07 17:07:04 UTC]

Its only fine because you have a newer version of patch which ignores line ending, the diff in the repository has DOS line endings and thats bad !

[Comment 3 Helmut Auer 2013-07-07 17:57:42 UTC]

P.S: Just install patch-1.5.9 and try it again, or as I've written above load the file into a hexeditor and you can see the DOS line endings ...

[Comment 4 Tom Wijsman (TomWij) (RETIRED) 2013-07-09 20:45:31 UTC]

Sorry, which version of patch was this broken with and which version did this work with? I'm experiencing this myself too when working on packages, my editor sets line endings wrong; I can usually fix it with by using dos2unix or unix2dos.

[Comment 5 Helmut Auer 2013-07-09 22:30:09 UTC]

Hello
patch-1.6.1 can handle DOS line endings, patch-1.5.9 not

[Comment 6 Jorge Manuel B. S. Vicetto (RETIRED) 2013-07-10 00:02:50 UTC]

(In reply to Helmut Auer from comment #5)
> Hello
> patch-1.6.1 can handle DOS line endings, patch-1.5.9 not

I assume you mean patch-2.6.1 and patch-2.5.9.
I've hit this issue with DOS line endings a few years ago. Since 2.6.1 has stable keywords on all relevant arches, who is still using 2.5.9 and why?

[Comment 7 Helmut Auer 2013-07-10 05:56:17 UTC]

Sure :)

[Comment 8 Helmut Auer 2013-07-10 05:57:31 UTC]

P.S. Anyway its a bad thing to provide patches with DOS line endings ...

[Comment 9 Johannes Huber (RETIRED) 2013-07-10 20:31:49 UTC]

Thanks for reporting. Hopefully the patch is now fixed. Please sync in some hours to get the change.

+  10 Jul 2013; Johannes Huber <[e-mail]>
+  files/cmake-2.8.10.2-FindPythonLibs.patch:
+  Format patch with dos2unix, bug #476064.
+

[Comment 10 Helmut Auer 2013-07-10 22:05:09 UTC]

Thanks Johannes !