Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 475918 - =app-emulation/winetricks-20130629 needs sys-process/time dependency - Fails tests -- which: no time
Summary: =app-emulation/winetricks-20130629 needs sys-process/time dependency - Fails ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-06 08:26 UTC by Markus Walter
Modified: 2013-07-09 02:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (app-emulation:winetricks-20130629:20130705-155932.log,25.45 KB, text/plain)
2013-07-06 08:26 UTC, Markus Walter
Details
emerge --info (info.txt,6.25 KB, text/plain)
2013-07-06 08:27 UTC, Markus Walter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Walter 2013-07-06 08:26:58 UTC
Created attachment 352708 [details]
build log

On my hardened ~amd64 machine with gcc-4.8.1 I see the following failure when running the winetricks testsuite.

+ QUICKCHECK='flash spotify'
+ for tool in time cabextract unrar unzip 7z
++ which time
which: no time in (/usr/lib64/portage/bin/ebuild-helpers/xattr:/usr/lib64/portage/bin/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/x86_64-pc-linux-gnu/gcc-bin/4.8.1)
+ test '' = ''
+ echo 'Please install time.'
Please install time.
+ exit 1
make: *** [check] Error 1

Manually merging sys-process/time solves this issue so winetricks should probably depend on it.
Comment 1 Markus Walter 2013-07-06 08:27:14 UTC
Created attachment 352710 [details]
emerge --info
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-07-09 02:29:57 UTC
We want to completely disable winetricks's test suite since it requires external network access (not guaranteed from portage) and attempts to run wine (really bad idea from an ebuild environment - e.g. wine doesn't like to be run as the root user). And sys-process/time is only needed for the test suite, not for the main winetricks executable.

However, the test error's output also shows checks for unrar and 7z. These tools, as well as a wget, really are needed by winetricks to download and unpack various dlls, but they were missing from the ebuild's dependency list. This has now been fixed. Thanks for drawing attention to the problem!

+  09 Jul 2013; Alexandre Rostovtsev <tetromino@gentoo.org>
+  winetricks-20130629.ebuild, winetricks-99999999.ebuild:
+  Restrict tests (they require network access and try to start wine) and add
+  missing dependencies (bug #475918, thanks to Markus Oehme).