Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 475422 - net-misc/connman fails to emerge on uclibc system
Summary: net-misc/connman fails to emerge on uclibc system
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-01 14:02 UTC by Amadeusz Sławiński
Modified: 2013-10-06 20:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,9.74 KB, application/octet-stream)
2013-07-01 14:03 UTC, Amadeusz Sławiński
Details
proposed patch (connman_uclibc.patch,2.29 KB, patch)
2013-07-01 19:02 UTC, Amadeusz Sławiński
Details | Diff
proposed patch v2 (connman_uclibc-v2.patch,1.36 KB, patch)
2013-07-02 19:08 UTC, Amadeusz Sławiński
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Sławiński 2013-07-01 14:02:55 UTC
src/log.c:33:22: fatal error: execinfo.h: No such file or directory
compilation terminated.
make[1]: *** [src/log.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2


a bit of googling (in particular http://git.buildroot.net/buildroot/plain/package/enlightenment/enlightenment-no-execinfo.patch)
suggests that it may need to check for presence of header in some other way, although I haven't checked if it is needed to build it yet.

Reproducible: Always




Portage 2.1.12.2 (hardened/linux/uclibc/amd64, gcc-4.6.3, uclibc-0.9.33.2-r3, 3.9.7-hardened x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.9.7-hardened-x86_64-Intel-R-_Core-TM-_i3_CPU_M_350_@_2.27GHz-with-gentoo-2.2
KiB Mem:     2997004 total,   1299396 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Sun, 30 Jun 2013 00:45:01 +0000
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/uclibc:          0.9.33.2-r3
Repositories: gentoo x-hardened-development my_local_overlay
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-11.x"
CBUILD="x86_64-gentoo-linux-uclibc"
CFLAGS="-O3 -march=native -pipe"
CHOST="x86_64-gentoo-linux-uclibc"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O3 -march=native -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch webrsync-gpg xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/hardened-development /usr/local/portage"
SYNC=""
USE="X acpi alsa amd64 bash-completion bluetooth cli cracklib crypt cups cxx dbus dri dvd flac fortran gif gold hardened iconv icu ipv6 jpeg jpeg2k libnotify mmx mng modules mp3 mudflap ncurses nptl opengl openmp pax_kernel pcre pic png readline session sse sse2 sse4_2 ssl ssse3 tcpd threads tiff uclibc udev unicode usb v4l vim-syntax wacom xattr xft xinerama zlib zsh-completion" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="uclibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB pl" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" QEMU_SOFTMMU_TARGETS="x86_64 ppc" RUBY_TARGETS="ruby19 ruby18" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Amadeusz Sławiński 2013-07-01 14:03:10 UTC
Created attachment 352398 [details]
build.log
Comment 2 Anthony Basile gentoo-dev 2013-07-01 14:29:30 UTC
(In reply to Amadeusz Sławiński from comment #0)
> src/log.c:33:22: fatal error: execinfo.h: No such file or directory
> compilation terminated.
> make[1]: *** [src/log.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [all] Error 2
> 
> 

There are two ways to approach this 1) compile uclibc with UCLIBC_HAS_BACKTRACE or 2) put #ifdef __UCLIBC__ around the execinfo code or 3) better yet, add some backtrace check to the build system and add #ifdef __HAS_BACKTRACE__.

I'm preferring the last option because its portable ot other systems, and you *can* optionally have backtrace.
Comment 3 Amadeusz Sławiński 2013-07-01 19:02:06 UTC
Created attachment 352418 [details, diff]
proposed patch

Simple patch using suggested approach, if it does look good I will send it upstream.
Comment 4 SpanKY gentoo-dev 2013-07-02 16:32:17 UTC
Comment on attachment 352418 [details, diff]
proposed patch

>--- a/connman-1.15/src/log.c	2013-07-01 18:28:17.123258909 +0000
>+++ b/connman-1.15/src/log.c	2013-07-01 18:39:21.981269479 +0000
>@@ -110,6 +112,7 @@
> 	va_end(ap);
> }
> 
>+#ifdef HAVE_EXECINFO_H
> static void print_backtrace(unsigned int offset)
> {
> 	void *frames[99];
>@@ -211,12 +214,15 @@
> 	close(outfd[1]);
> 	close(infd[0]);
> }
>+#endif
> 
> static void signal_handler(int signo)
> {
> 	connman_error("Aborting (signal %d) [%s]", signo, program_exec);
> 
>+#ifdef HAVE_EXECINFO_H
> 	print_backtrace(2);
>+#endif
> 
> 	exit(EXIT_FAILURE);
> }

put the ifdef inside of the func and you won't need to protect the call points

static void print_backtrace(unsigned int offset)
{
#ifdef HAVE_EXECINFO_H
........
#endif
}
Comment 5 Amadeusz Sławiński 2013-07-02 19:08:56 UTC
Created attachment 352466 [details, diff]
proposed patch v2

Thanks for suggestion.
Comment 6 Anthony Basile gentoo-dev 2013-07-04 14:47:39 UTC
(In reply to Amadeusz Sławiński from comment #5)
> Created attachment 352466 [details, diff] [details, diff]
> proposed patch v2
> 
> Thanks for suggestion.

This is good.  Send it upstream.  Here's their bugzilla.  I don't know how they accept patches though but you might start there:

https://bugs.meego.com/describecomponents.cgi?product=Connection%20Manager
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2013-10-06 20:27:44 UTC
+*connman-1.18 (06 Oct 2013)
+*connman-1.17 (06 Oct 2013)
+*connman-1.16 (06 Oct 2013)
+
+  06 Oct 2013; Tony Vroon <chainsaw@gentoo.org> +connman-1.16.ebuild,
+  +connman-1.17.ebuild, +connman-1.18.ebuild,
+  +files/connman-1.16-execinfo-assumptions.patch:
+  Now compatible with uclibc thanks to Amadeusz Sławiński, closes bug
+  #475422. Version bumps as requested by José Romildo Malaquias in bug
+  #486784. DHCPv6 support almost RFC-compliant now. Machine-generated config
+  files no longer have trailing whitespace. 1.18 will be the stable candidate.