this shouldnt be an useflag at all. the custom-cflags code in the ebuild is at best ugly. the previous way was just fine: --extra-cflags=$CFLAGS will _append_ the cflags and thus override the defaults. it also has the advantage to build with -O3 if the user has not set -O in its CFLAGS (building x264 with -O0 might not work).
What previous way? The code that implements this was copied verbatim from the 0.0.20120707 ebuild.
(In reply to Patrick McLean from comment #1) > What previous way? http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/x264/x264-9999.ebuild?r1=1.6&r2=1.7
I agree, USE custom-cflags should be dropped. But it works fine without --extra-*, if you add them, you will have same flags twice in gcc commands.
(In reply to Nikoli from comment #3) > I agree, USE custom-cflags should be dropped. But it works fine without > --extra-*, if you add them, you will have same flags twice in gcc commands. sounds good indeed
done you should start by submitting patches if you want to proxy maintain it...
