Created attachment 351328 [details] x264-0.0.20130423.ebuild Please commit attached ebuilds and change media-libs/x264 in packages to media-libs/x264:= where appropriate. What changed in reference to x264-0.0.20120707: EAPI5 sub-slots use 'stable' git branch instead of 'master' set correct and full version number: $ x264 -V|head -n1 x264 0.130.2282 1db4621 update yasm dep add USE avs add USE opencl remove ugly USE custom-cflags building gcc-4.8 is fixed upstream ability to build x264cli with internal libx264 fixed media-libs/x264 dep in x264-encoder cosmetics For both opencl and avs dlopen is used, not linking. virtual/opencl and avxsynsh are not required at build time. Also it is safe to not install them even if you enabled USE avs and opencl, you will have no problems at runtime. avs: http://git.videolan.org/?p=x264.git;a=commit;h=eaae05ea3f104dc9fa948327e10649ec693adf0e opencl: http://git.videolan.org/?p=x264.git;a=commit;h=3a5f6c0aeacfcb21e7853ab4879f23ec8ae5e042 http://git.videolan.org/?p=x264.git;a=commit;h=a3ac64b8b467eea1264c0053022893bc84b2e9a2 Did not add prefix related workarounds to src_prepare because: a) current portage ebuilds do not have any solaris keywords bug #351219#c6 b) macos related sed seems not required anymore: <lu_zero> the macosx change should get dropped All attached ebuilds are now also in multimedia overlay. There were no version bumps of x264 packages for almost year, seems not much people care about x264. I would to proxy maintain it.
Created attachment 351330 [details] live ebuild
Created attachment 351332 [details] x264-encoder-0.0.20130423.ebuild
Created attachment 351334 [details] live ebuild
could you please attach diffs to current in-tree 9999 ebuilds? it'd be much easier to review (I assume the snapshot ebuild will be very similar) for example: DEPEND=" amd64? ( ${ASM_DEP} ) x86? ( ${ASM_DEP} ) x86-fbsd? ( ${ASM_DEP} ) opencl? ( dev-lang/perl ) " amd64-fbsd is missing
also, that system-libx264 useflag thing is a very bad idea imho: we should always use it and be done.
media-libs/x264-0.0.20130506 and media-video/x264-encoder-0.0.20130506 are now in CVS.
(In reply to Patrick McLean from comment #6) > media-libs/x264-0.0.20130506 and media-video/x264-encoder-0.0.20130506 are > now in CVS. wtf? thanks for completely ignoring me... I pointed out at least 2 issues even without diff
But why ebuilds have '20130506' in version? Both stable and master branches of x264 git do not have any commits with this date. And today is not 20130506.
I think the bug is not fixed in tree, it needs further discussion. You dropped several changes from attached ebuilds without any comment or explanation, also some silently added changes are questionable.
Upstream recommended that as a "stable" version.
