Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 472808 - Version Bump dev-python/setuptools-0.7.2 & test fails
Summary: Version Bump dev-python/setuptools-0.7.2 & test fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL: https://bitbucket.org/pypa/setuptools...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 472810
  Show dependency tree
 
Reported: 2013-06-10 05:51 UTC by Justin Lecher (RETIRED)
Modified: 2013-06-14 03:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild + a patch for py2.5 (setuptools-0.7.2.ebuild,2.18 KB, text/plain)
2013-06-13 15:26 UTC, Ian Delaney (RETIRED)
Details
ebuild + a patch for py2.5 (setuptools-0.7.2.ebuild,1.96 KB, text/plain)
2013-06-13 16:32 UTC, Ian Delaney (RETIRED)
Details
ebuild + a patch for py2.5 (setuptools-0.7.2.ebuild,2.09 KB, text/plain)
2013-06-14 02:17 UTC, Ian Delaney (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2013-06-10 05:51:38 UTC
Please bump.
I already got a package requesting that version.

https://pypi.python.org/packages/source/s/setuptools/
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2013-06-13 15:26:24 UTC
Created attachment 350890 [details]
ebuild + a patch for py2.5

py2.5 suffers a fail on a silly technicality, i.e. not able to write to system installed py2.5.
pypy1.9 suffers FAILED (failures=1, errors=4)
pypy2.0 just the 1.
See bug filed upstream.
As for install phase if it's not good with distutils-r1 defaults it can get cleaned up on the tests getting fixed.
Comment 2 Mike Gilbert gentoo-dev 2013-06-13 15:37:20 UTC
(In reply to Ian Delaney from comment #1)
> Created attachment 350890 [details]
> ebuild + a patch for py2.5

That ebuild could use some polishing.

pushd "${BUILD_DIR}"../

This is probably broken, and I'm not sure why it is there in the first place. And you left out the corresponding "popd".

sed -e "s:run_setup(test_setup_py, ['install']):run_setup(test_setup_py, ['build']):"

Why are you replacing 'install' with 'build' here? I don't see any explanation for this. Also, the patch makes this redundant.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2013-06-13 16:32:11 UTC
Created attachment 350894 [details]
ebuild + a patch for py2.5

hmm I forgot to delete that part, the sed statement didn't work and I made the patch.
The reason lies explained enough in the filed bug, which is why I put it there, but to repeat, py2.5 fails over not being able to write to the system installed py2.5.  Who'd a thought?
Giving it a build dir instead makes it pass what it shouldn't fail, and is intended more or less as a place holder
Comment 4 Mike Gilbert gentoo-dev 2013-06-13 17:22:09 UTC
(In reply to Ian Delaney from comment #3)
> The reason lies explained enough in the filed bug, which is why I put it
> there, but to repeat, py2.5 fails over not being able to write to the system
> installed py2.5.  Who'd a thought?
> Giving it a build dir instead makes it pass what it shouldn't fail, and is
> intended more or less as a place holder

This explanation should be given in the patch header, along with a link to the bug report.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2013-06-14 02:17:45 UTC
Created attachment 350926 [details]
ebuild + a patch for py2.5

sure
Comment 6 Mike Gilbert gentoo-dev 2013-06-14 02:44:34 UTC
You can drop distutil-r1_python_prepare from python_prepare; that function does not exist.

Other than that, looks good to me.
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2013-06-14 03:36:09 UTC
  14 Jun 2013; Ian Delaney <idella4@gentoo.org>
  +files/setuptools-0.7.2-test-easy.patch, +setuptools-0.7.2.ebuild:
  bump; switch to setuptools proper rather than distribute, fixes Bug #472808