Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 470596 - x11-drivers/ati-drivers fails with kernel 3.10-rc due to missing create_proc_entry
Summary: x11-drivers/ati-drivers fails with kernel 3.10-rc due to missing create_proc_...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-19 00:35 UTC by Fabio Rossi
Modified: 2013-06-20 12:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ati-drivers-13.1_pre897:20130513-204144.log.gz (x11-drivers:ati-drivers-13.1_pre897:20130513-204144.log.gz,2.19 KB, text/plain)
2013-05-19 00:35 UTC, Fabio Rossi
Details
.config for linux 3.10-rc5 (.config,63.49 KB, text/plain)
2013-06-09 21:00 UTC, Alex Xu (Hello71)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Rossi 2013-05-19 00:35:55 UTC
Created attachment 348630 [details]
ati-drivers-13.1_pre897:20130513-204144.log.gz

With the next kernel release the create_proc_entry will be removed, this causes problems during the compilation of ati-drivers, both legacy and last 13.4 versions are affected. Here is attached the log during the unsuccessful recompilation.
Comment 1 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-05-20 20:57:29 UTC
Is that still an issue with the current ebuild?
Comment 2 emil karlson 2013-05-20 21:33:01 UTC
I pushed also legacy branch compile fixes to x11 overlay, please test it as I can't.
Comment 3 Fabio Rossi 2013-05-21 19:10:45 UTC
tested the legacy driver in the x11 overlay, it works! thanks
Comment 4 Alex Xu (Hello71) 2013-06-04 22:34:29 UTC
ati-drivers-13.6_beta from x11 overlay with linux-3.10-proc.diff mtime 2013-06-04 17:56:23.300835735 -0400

/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_create_proc_dir':
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6361:10: error: implicit declaration of function 'create_proc_entry' [-Werror=implicit-function-declaration]
          dir = create_proc_entry(name, S_IFDIR | access, firegl_stub_root);
          ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6361:14: warning: assignment makes pointer from integer without a cast [enabled by default]
          dir = create_proc_entry(name, S_IFDIR | access, firegl_stub_root);
              ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6363:14: warning: assignment makes pointer from integer without a cast [enabled by default]
          dir = create_proc_entry(name, S_IFDIR | access, (struct proc_dir_entry *)root_dir);
              ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_create_proc_entry':
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6393:9: warning: assignment makes pointer from integer without a cast [enabled by default]
     ent = create_proc_entry(name, access_mode, (struct proc_dir_entry *)root_dir);
         ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6397:12: error: dereferencing pointer to incomplete type
         ent->read_proc = (read_proc_t *)read_fn;
            ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6398:12: error: dereferencing pointer to incomplete type
         ent->write_proc = (write_proc_t *)write_fn;
            ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6399:12: error: dereferencing pointer to incomplete type
         ent->data = private_data;
            ^
cc1: some warnings being treated as errors
Comment 5 Alex Xu (Hello71) 2013-06-04 22:35:24 UTC
Using 042dd60ca6dec9a02cefa8edd67de386e35755d6 2013-06-04 06:34:51 +0900 from git.kernel.org/.../torvalds/linux.git.
Comment 6 emil karlson 2013-06-09 20:06:48 UTC
(In reply to Alex Xu from comment #5)
> Using 042dd60ca6dec9a02cefa8edd67de386e35755d6 2013-06-04 06:34:51 +0900
> from git.kernel.org/.../torvalds/linux.git.

Can you post your kernel config.
Comment 7 Alex Xu (Hello71) 2013-06-09 21:00:46 UTC
Created attachment 350578 [details]
.config for linux 3.10-rc5

distcc[27775] ERROR: compile /tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c on 127.0.0.1 failed
distcc[27775] (dcc_build_somewhere) Warning: remote compilation of '/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c' failed, retrying locally
distcc[27775] Warning: failed to distribute /tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c to 127.0.0.1, running locally instead
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_create_proc_dir':
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6361:10: error: implicit declaration of function 'create_proc_entry' [-Werror=implicit-function-declaration]
          dir = create_proc_entry(name, S_IFDIR | access, firegl_stub_root);
          ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6361:14: warning: assignment makes pointer from integer without a cast [enabled by default]
          dir = create_proc_entry(name, S_IFDIR | access, firegl_stub_root);
              ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6363:14: warning: assignment makes pointer from integer without a cast [enabled by default]
          dir = create_proc_entry(name, S_IFDIR | access, (struct proc_dir_entry *)root_dir);
              ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c: In function 'KCL_create_proc_entry':
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6393:9: warning: assignment makes pointer from integer without a cast [enabled by default]
     ent = create_proc_entry(name, access_mode, (struct proc_dir_entry *)root_dir);
         ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6397:12: error: dereferencing pointer to incomplete type
         ent->read_proc = (read_proc_t *)read_fn;    
            ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6398:12: error: dereferencing pointer to incomplete type
         ent->write_proc = (write_proc_t *)write_fn; 
            ^
/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c:6399:12: error: dereferencing pointer to incomplete type
         ent->data = private_data;
            ^
cc1: some warnings being treated as errors
distcc[27775] ERROR: compile /tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.c on localhost failed
make[2]: *** [/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x/firegl_public.o] Error 1
make[1]: *** [_module_/tmp/portage/x11-drivers/ati-drivers-13.6_beta/work/common/lib/modules/fglrx/build_mod/2.6.x] Error 2
make[1]: Leaving directory `/home/alex/linux'
make: *** [kmod_build] Error 2
Comment 8 emil karlson 2013-06-10 16:39:37 UTC
This should be now fixed in x11 overlay. I only compile tested this so far, but I made no functional changes, only removed some lines so successful compile probably means it should work.

Could you please test this?
Comment 9 Alex Xu (Hello71) 2013-06-13 10:40:41 UTC
Yeah, works fine. Still crashes all the time though.
Comment 10 emil karlson 2013-06-13 11:25:02 UTC
(In reply to Alex Xu from comment #9)
> Yeah, works fine. Still crashes all the time though.

Can you give me any details?

1. When did this problem first appear, can you try linux-3.9, if unsure.

2. Any kernel log or something.
Comment 11 Alex Xu (Hello71) 2013-06-13 20:11:02 UTC
There's the well-known crash on Konsole resize and I suspect there are possibly some other triggers.

Xorg segfaults somewhere in a library with fglrx in the backtrace; I don't have debug symbols enabled globally and I'm assuming that the xorg driver is crapping somewhere in memory; not worth going after in a proprietary driver.
Comment 12 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-06-20 12:36:02 UTC
As the build error is now gone I am marking this as fixed. Any further issues with kernel 3.10 are best discussed in a separate bug report.