Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 470210 - sys-devel/patch-2.7.1-r1 - checking for ed... ${PORTAGE_TMPDIR}/sys-devel/patch-2.7.1-r1/image/
Summary: sys-devel/patch-2.7.1-r1 - checking for ed... ${PORTAGE_TMPDIR}/sys-devel/pat...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH, TESTFAILURE
: 443274 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-05-17 22:23 UTC by Roman Žilka
Modified: 2013-05-21 21:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix ./configure to ignore $ED from the environment (patch-2.7.1-ignore-ED-variable.patch,818 bytes, patch)
2013-05-17 22:29 UTC, Roman Žilka
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Žilka 2013-05-17 22:23:39 UTC
The test phase of sys-devel/patch-2.7.1-r1 fails: test case "crlf-handling" and another one ("need-filename", I think). It turns out the problem lies in calling the ed editor which both these test cases make use of. They thinks ed's path is ${PORTAGE_BUILDDIR}/image and try to call that directly. This path gets there through ./configure, which checks if the variable ED is set in the environment and if true, considers is to point at the "ed" binary.

Please either rename $ED in Portage or fix patch's ./configure. I don't know how firmly $ED is built into Portage, but patch's ./configure is relatively standard and other packages could exhibit equivalent check procedures, leading to the same error.

This bug is similar to bug 293603, but I don't have the variable ED set in the shell environment when calling emerge.

FWIW, the only reference to $ED in the "environment" file is in gen_usr_ldscript() from toolchain-funcs.eclass.

Reproducible: Always
Comment 1 Roman Žilka 2013-05-17 22:29:16 UTC
Created attachment 348568 [details, diff]
fix ./configure to ignore $ED from the environment
Comment 2 SpanKY gentoo-dev 2013-05-21 17:26:52 UTC
Comment on attachment 348568 [details, diff]
fix ./configure to ignore $ED from the environment

we don't generally patch things like this.  would be simpler to unset $ED in the ebuild itself.
Comment 3 SpanKY gentoo-dev 2013-05-21 17:36:12 UTC
should be all set now in the tree; thanks for the report!

Commit message: Do not let $ED from the EAPI mess up the search for `ed`
http://sources.gentoo.org/sys-devel/patch/patch-2.7.1-r1.ebuild?r1=1.3&r2=1.4
Comment 4 SpanKY gentoo-dev 2013-05-21 21:20:16 UTC
*** Bug 443274 has been marked as a duplicate of this bug. ***