Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469188 - net-irc/weechat-0.4.0 USE=doc should depend on app-text/asciidoc and dev-util/source-highlight
Summary: net-irc/weechat-0.4.0 USE=doc should depend on app-text/asciidoc and dev-util...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tomáš Chvátal (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-05-09 13:57 UTC by M. B.
Modified: 2013-05-14 09:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild.patch (weechat.patch,1.00 KB, patch)
2013-05-09 13:57 UTC, M. B.
Details | Diff
weechat-0.4.0-r1.ebuild (weechat-0.4.0-r1.ebuild,3.20 KB, text/plain)
2013-05-09 13:59 UTC, M. B.
Details
ebuild.patch (file_469188.txt,2.91 KB, text/plain)
2013-05-10 18:33 UTC, M. B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description M. B. 2013-05-09 13:57:11 UTC
Created attachment 347846 [details, diff]
ebuild.patch

weechat provides further docs, as long as app-text/asciidoc and dev-util/source-highlight are available.
i also added some logic (hunk #3) to filter out the LINGUAS not wanted.
Comment 1 M. B. 2013-05-09 13:59:12 UTC
Created attachment 347848 [details]
weechat-0.4.0-r1.ebuild

the new ebuild.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-05-09 14:10:37 UTC
(In reply to comment #1)
> Created attachment 347848 [details]
> weechat-0.4.0-r1.ebuild

An ebuild revision isn't needed.
Comment 3 M. B. 2013-05-10 18:33:17 UTC
Created attachment 347952 [details]
ebuild.patch

There are further issues with the ebuild's dependencies.
Here is a summed-up description of all the changes now.
- I removed the "crypt" useflag altogether. Instead libgcrypt is a standard-dependency now. Weechat will not build without it.
- I put the deps for creating the additional documentation to build-time dependencies.
- nls support needs some form of libintl during runtime but depends on gettext for buildtime (in the CMake files
- zlib is required to build. it will fail without.

- logic to remove superfluous extra-documentation is seding the build-files

- alias and rmodifier modules (listed as useflags) were not listed as cmake-utils_use_enable.

- the "scripts" useflag should probably be removed and instead it (the cmake-utils_use_enable for scripts and script) should both be triggered by enabling any of the scripting plugins.
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2013-05-14 09:34:15 UTC
Thanks for the patch.

I applied it to the live ebuild and it will propagate to the next release.

It should be released in 5 days anyway.