Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469084 - sys-apps/findutils-4.5.11[-userland_GNU] does not `rm` oldfind correctly
Summary: sys-apps/findutils-4.5.11[-userland_GNU] does not `rm` oldfind correctly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 469494 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-05-08 16:27 UTC by Christian Bricart
Modified: 2013-05-12 18:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Bricart 2013-05-08 16:27:18 UTC
=sys-apps/findutils/findutils-4.5.11 introduced the following:

historically, there is:

src_configure() {
  ..
  use userland_GNU || myconf=" --program-prefix=g"
  ..
}

while (new) in:

src_install():

  ..
  # We don't need this, so punt it.
  rm "${ED}"/usr/bin/oldfind "${ED}"/usr/share/man/man1/oldfind.1 || die
  ..
}

which will result in die() on e.g. *-fbsd due to the missing prepended "g"..


Reproducible: Always

Steps to Reproduce:
# emerge = =sys-apps/findutils-4.5.11
Actual Results:  
>>> Emerging (1 of 1) sys-apps/findutils-4.5.11
 * findutils-4.5.11.tar.gz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                                [ ok ]
>>> Unpacking source...
>>> Unpacking findutils-4.5.11.tar.gz to /var/tmp/portage/sys-apps/findutils-4.5.11/work
>>> Source unpacked in /var/tmp/portage/sys-apps/findutils-4.5.11/work
>>> Preparing source in /var/tmp/portage/sys-apps/findutils-4.5.11/work/findutils-4.5.11 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/sys-apps/findutils-4.5.11/work/findutils-4.5.11 ...
 * econf: updating findutils-4.5.11/build-aux/config.sub with /usr/share/gnuconfig/config.sub
 * econf: updating findutils-4.5.11/build-aux/config.guess with /usr/share/gnuconfig/config.guess
./configure --prefix=/usr --build=x86_64-gentoo-freebsd9.1 --host=x86_64-gentoo-freebsd9.1 --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib --with-packager=Gentoo --with-packager-version=4.5.11 --with-packager-bug-reports=http://bugs.gentoo.org/ --enable-nls --libexecdir=$(libdir)/find --program-prefix=g
...
gmake[2]: Leaving directory `/var/tmp/portage/sys-apps/findutils-4.5.11/work/findutils-4.5.11'
gmake[1]: Leaving directory `/var/tmp/portage/sys-apps/findutils-4.5.11/work/findutils-4.5.11'
rm: /var/tmp/portage/sys-apps/findutils-4.5.11/image//usr/bin/oldfind: No such file or directory
rm: /var/tmp/portage/sys-apps/findutils-4.5.11/image//usr/share/man/man1/oldfind.1: No such file or directory
 * ERROR: sys-apps/findutils-4.5.11 failed (install phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  93:  Called src_install
 *   environment, line 2398:  Called die
 * The specific snippet of code:
 *       rm "${ED}"/usr/bin/oldfind "${ED}"/usr/share/man/man1/oldfind.1 || die
 * 
 * If you need support, post the output of `emerge --info '=sys-apps/findutils-4.5.11'`,
 * the complete build log and the output of `emerge -pqv '=sys-apps/findutils-4.5.11'`.
 * The complete build log is located at '/var/tmp/portage/sys-apps/findutils-4.5.11/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-apps/findutils-4.5.11/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-apps/findutils-4.5.11/work/findutils-4.5.11'
 * S: '/var/tmp/portage/sys-apps/findutils-4.5.11/work/findutils-4.5.11'

>>> Failed to emerge sys-apps/findutils-4.5.11, Log file:

>>>  '/var/tmp/portage/sys-apps/findutils-4.5.11/temp/build.log'
 * 
 * The following package has failed to build or install:
 * 
 *  (sys-apps/findutils-4.5.11::gentoo, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/sys-apps/findutils-4.5.11/temp/build.log'
 * 



Portage 2.2.0_alpha174 (default/bsd/fbsd/amd64/9.1, gcc-4.7.2, freebsd-lib-9.1, 9.1-r1-Gentoo amd64)
Comment 1 SpanKY gentoo-dev 2013-05-09 17:29:07 UTC
should be all set now in the tree; thanks for the report!

Commit message: Update oldfind removal to include program prefix
http://sources.gentoo.org/sys-apps/findutils/findutils-4.5.11.ebuild?r1=1.2&r2=1.3
Comment 2 Naohiro Aota gentoo-dev 2013-05-12 08:54:21 UTC
*** Bug 469494 has been marked as a duplicate of this bug. ***
Comment 3 Naohiro Aota gentoo-dev 2013-05-12 10:59:22 UTC
program_prefix is local and so not effective in src_install. The problem still occur.
Comment 4 SpanKY gentoo-dev 2013-05-12 18:05:32 UTC
should be all set now in the tree; thanks for the report!

Commit message: Drop local markings on program_prefix since it is used in multiple funcs
http://sources.gentoo.org/sys-apps/findutils/findutils-4.5.11.ebuild?r1=1.3&r2=1.4