468844 – kde-base/kopete-4.10.3[v4l] fails to build with recent kernels

Bug 468844 - kde-base/kopete-4.10.3[v4l] fails to build with recent kernels

Summary: kde-base/kopete-4.10.3[v4l] fails to build with recent kernels

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] KDE (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo KDE team

URL:	https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords:	PATCH

Duplicates (1):	468858 (view as bug list)
Depends on:
Blocks:

Reported:	2013-05-07 09:31 UTC by Erich Seifert
Modified:	2013-05-10 17:20 UTC (History)
CC List:	9 users (show)

See Also:	http://bugzilla.redhat.com/show_bug.cgi?id=946924
Package list:
Runtime testing required:	---

Attachments
Patch to make deprecated V4L2 controls in Kopete optional (kopete-4.10.3-fix-deprecated-v4l-controls.patch,760 bytes, patch) 2013-05-07 09:33 UTC, Erich Seifert	Details \| Diff
build.log (build.log,254.90 KB, text/plain) 2013-05-07 09:35 UTC, Erich Seifert	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Erich Seifert 2013-05-07 09:31:49 UTC

kde-base/kopete-4.10.3 with v4l USE flag fails to build with kernel 3.9 and kernel headers 3.9. The errors are caused by undeclared V4L2 constants which have been removed since kernel 3.7.

Reproducible: Always

Steps to Reproduce:
1. emerge kde-base/kopete-4.10.3

Actual Results:  
Compilation fails with an error:
/var/tmp/portage/kde-base/kopete-4.10.3/work/kopete-4.10.3/kopete/libkopete/avdevice/videodevice.cpp: In member function 'const char* Kopete::AV::VideoDevice::getUnifiedV4L2StdCtrlName(quint32)':
/var/tmp/portage/kde-base/kopete-4.10.3/work/kopete-4.10.3/kopete/libkopete/avdevice/videodevice.cpp:3064:8: error: 'V4L2_CID_HCENTER' was not declared in this scope
/var/tmp/portage/kde-base/kopete-4.10.3/work/kopete-4.10.3/kopete/libkopete/avdevice/videodevice.cpp:3065:8: error: 'V4L2_CID_VCENTER' was not declared in this scope


Expected Results:  
Should build and install without errors.

I also filed an upstream bug for the issue (see URL).

Comment 1 Erich Seifert 2013-05-07 09:33:58 UTC

Created attachment 347580 [details, diff]
Patch to make deprecated V4L2 controls in Kopete optional

This is the patch I attached to the upstream bug.

Comment 2 Erich Seifert 2013-05-07 09:35:07 UTC

Created attachment 347582 [details]
build.log

Comment 3 Johannes Huber (RETIRED) gentoo-dev

2013-05-07 14:43:48 UTC

*** Bug 468858 has been marked as a duplicate of this bug. ***

Comment 4 Michael Palimaka (kensington) gentoo-dev

2013-05-08 13:34:06 UTC

I have filed a review request upstream for this patch.

Comment 5 Silvio 2013-05-10 16:35:02 UTC

same problem here

Comment 6 Michael Palimaka (kensington) gentoo-dev

2013-05-10 17:20:28 UTC

Thanks, a slightly modified patch was merged upstream and backported in CVS.

+  10 May 2013; Michael Palimaka <kensington@gentoo.org>
+  +files/kopete-4.10.3-v4l.patch, kopete-4.10.3.ebuild:
+  Backport patch from upstream to fix build with USE="v4l" and Linux 3.9, wrt
+  bug #468844.

http://websvn.kde.org/?view=revision&revision=1353735
http://websvn.kde.org/?view=revision&revision=1353736