Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468570 - media-sound/cantata-1.0.3 version bump
Summary: media-sound/cantata-1.0.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-04 13:12 UTC by Nikoli
Modified: 2013-06-09 12:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
metadata.xml (metadata.xml,478 bytes, text/xml)
2013-06-08 09:43 UTC, Nikoli
Details
patch1 (cantata-1.0.3-audiocd-automagic.patch,1.65 KB, patch)
2013-06-08 09:43 UTC, Nikoli
Details | Diff
patch2 (cantata-1.0.3-system-qjson.patch,1016 bytes, patch)
2013-06-08 09:43 UTC, Nikoli
Details | Diff
ebuild, works for me (cantata-1.0.3.ebuild,2.17 KB, text/plain)
2013-06-08 09:44 UTC, Nikoli
Details
ebuild, works for me (cantata-1.0.3.ebuild,2.22 KB, text/plain)
2013-06-08 12:35 UTC, Nikoli
Details
ebuild, works for me (cantata-1.0.3.ebuild,2.24 KB, text/plain)
2013-06-08 15:42 UTC, Nikoli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2013-05-04 13:12:18 UTC
cantata-1.0.1 was released.
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2013-05-09 14:06:09 UTC
Today 1.0.2  was released
Comment 2 Chris Reffett (RETIRED) gentoo-dev Security 2013-05-22 14:20:20 UTC
Bumped in KDE overlay, will move to tree in a few days.
Comment 3 Johannes Huber (RETIRED) gentoo-dev 2013-05-22 17:11:29 UTC
(In reply to comment #2)
> Bumped in KDE overlay, will move to tree in a few days.

@Chris: Did you see the solid2 stuff in the cmake files? I would say this is a total mess by upstream.
Comment 4 Chris Reffett (RETIRED) gentoo-dev Security 2013-05-22 19:36:35 UTC
Hm, no, I didn't really understand what was going on there. I'll have a look and dig more into the code. Also, it looks like there's now some new feature for online music services, "Jamendo" or something like that and one or two others, I'm open to suggestions of what to name the USE flag to toggle that since it's a build-time setting. Or we can leave it enabled by default since it doesn't pull any dependencies.
Comment 5 Chris Reffett (RETIRED) gentoo-dev Security 2013-05-22 19:55:54 UTC
On further investigation, it appears that when cantata is built Qt-only (that is, USE=-kde), it uses a bundled copy of solid. Johu was referring to the fact that there is a new option to use a bundled version of solid which works for udisks2 (from KDE 4.10.1, it seems). We could have a USE flag control this, force the udisks2 option (which will only apply to Qt builds, KDE builds just rely on the system version of solid anyway), or force cantata to use KDE and remove the Qt build option (will annoy people who want smaller systems, but gets rid of the problem of bundled libs). I don't see an easy way to just install Solid, since the CMakeLists.txt file checks if KDE is installed, and Solid depends on kdelibs and the other big KDE packages.

@qt team: what are your thoughts on the matter?
Comment 6 Nikoli 2013-05-23 02:32:44 UTC
Please keep support for online services optional.
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2013-05-23 02:50:23 UTC
(In reply to comment #4)
> Hm, no, I didn't really understand what was going on there. I'll have a look
> and dig more into the code. Also, it looks like there's now some new feature
> for online music services, "Jamendo" or something like that and one or two
> others, I'm open to suggestions of what to name the USE flag to toggle that
> since it's a build-time setting. Or we can leave it enabled by default since
> it doesn't pull any dependencies.

I don't mind having them always enabled (i.e. no USE flag), as long as they don't pull any new dependency.
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2013-05-23 02:54:37 UTC
(In reply to comment #5)
> @qt team: what are your thoughts on the matter?

I'm sure someone will complain if you remove the ability to build a qt-only version.

That being said, I didn't quite understand what our options are. Is solid needed even with USE=-kde ?
Comment 9 Chris Reffett (RETIRED) gentoo-dev Security 2013-05-23 06:34:01 UTC
If you build with KDE support, it will end up using the copy of solid on the system, whereas if you build the Qt-only version, it will build with a bundled copy of solid. But yes, solid seems to be required either way, as best I can tell. I will also double-check that there are in fact no extra requirements for the streaming services.
Comment 10 Ben de Groot (RETIRED) gentoo-dev 2013-05-23 13:53:07 UTC
(In reply to comment #8)
> (In reply to comment #5)
> > @qt team: what are your thoughts on the matter?
> 
> I'm sure someone will complain if you remove the ability to build a qt-only
> version.

I would be that someone. Cantata is my preferred MPD client. I run Razor-qt without any KDE on my Gentoo system, and I would like to keep it that way. So taking away that option is not acceptable to me.
Comment 11 Nikoli 2013-06-08 05:29:39 UTC
USE webkit seems wrong - it is not aware about qt5.
Comment 12 Nikoli 2013-06-08 06:17:59 UTC
Version bump was done with a LOT mistakes. Ebuild has dozens of missing, obsolete and automagic deps:
Qt5 is automagic, ENABLE_QT5 cmake option should be used.
taglib and taglib-extras are automagic, -DENABLE_TAGLIB=OFF -DENABLE_TAGLIB_EXTRAS=OFF should be used.
Upstream does not use qtwebkit anymore.
cdparanoia, libcddb, lame and musicbrainz are missing in *DEPEND and automagic, this patch should be used
https://code.google.com/p/cantata/source/detail?r=2750
udev is automagic.
cmake has ENABLE_UDISKS2 option.
zlib is missing in DEPEND and RDEPEND.
Comment 13 Nikoli 2013-06-08 06:30:36 UTC
Also upstream uses internal copy of qjson instead of system, asked to fix:
https://code.google.com/p/cantata/issues/detail?id=229
Comment 14 Nikoli 2013-06-08 09:43:09 UTC
Created attachment 350392 [details]
metadata.xml
Comment 15 Nikoli 2013-06-08 09:43:30 UTC
Created attachment 350394 [details, diff]
patch1
Comment 16 Nikoli 2013-06-08 09:43:46 UTC
Created attachment 350396 [details, diff]
patch2
Comment 17 Nikoli 2013-06-08 09:44:07 UTC
Created attachment 350398 [details]
ebuild, works for me
Comment 18 Nikoli 2013-06-08 12:35:57 UTC
Created attachment 350404 [details]
ebuild, works for me

Forgot about lame.
Comment 19 Nikoli 2013-06-08 15:42:29 UTC
Created attachment 350412 [details]
ebuild, works for me

Add dev-libs/qjson
Comment 20 Johannes Huber (RETIRED) gentoo-dev 2013-06-09 12:20:44 UTC
Version media-sound/cantata-1.0.3 is already in tree. Please contribute to bug 472140 instead.