Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 467954 - www-client/chromium-27.0.1453.65 fails to build with selinux use-flag disabled
Summary: www-client/chromium-27.0.1453.65 fails to build with selinux use-flag disabled
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-30 07:33 UTC by Dominik Kriegner
Modified: 2013-05-01 21:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log.bz2,233.87 KB, application/x-bzip2)
2013-04-30 07:39 UTC, Dominik Kriegner
Details
proposed patch (zygote-fix.patch,403 bytes, patch)
2013-04-30 09:31 UTC, Dominik Kriegner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Kriegner 2013-04-30 07:33:53 UTC
when I build chromium with the selinux flag disabled I find a build error, which is in my opinion due to an extra bracket in the content/zygote/zygote_main_linux.cc:442:61 file. I did not test but think this could also affect newer versions since I see the same code in the trunk sources on chromium.org

Reproducible: Always

Steps to Reproduce:
1. build chromium with selinux use-flag disabled
Comment 1 Dominik Kriegner 2013-04-30 07:39:16 UTC
Created attachment 346950 [details]
build log
Comment 2 Dominik Kriegner 2013-04-30 07:42:59 UTC
I stumbled accross this problem because chromium was not usable with selinux (in permissive mode) without starting it with chromium --no-sandbox (as suggested in bug #465574
Comment 3 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-04-30 09:17:02 UTC
content/zygote/zygote_main_linux.cc: In function ‘bool content::EnterSandbox(sandbox::SetuidSandboxClient*, bool*, bool*)’:
content/zygote/zygote_main_linux.cc:442:61: error: expected ‘;’ before ‘)’ token
Comment 4 Dominik Kriegner 2013-04-30 09:31:02 UTC
Created attachment 346964 [details, diff]
proposed patch

using this patch i could successfully build chromium with use flag selinux disabled
Comment 5 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-05-01 21:32:45 UTC
I think this is completely broken and unmaintained upstream. Removed.

  01 May 2013; Pawel Hajdan jr
  chromium-27.0.1453.65.ebuild, chromium-28.0.1490.2.ebuild,
  chromium-9999-r1.ebuild:
  Disable unmaintained upstream SELinux mode, bug #465574 by swift, bug #467954
  by Dominik Kriegner.

Thank you for the patch by the way. I think it's good and it works - however, there are other problems with this way of SELinux sandboxing, see the other bug above.

If anyone is interested in making it work upstream, I can help review changes.