Hi, app-admin/rsyslog (tried app-admin/rsyslog-7.2.7) doesn't build with the latest dev-libs/json-c-0.11: checking for JSON_C... no configure: error: Package requirements (json) were not met: No package 'json' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables JSON_C_CFLAGS and JSON_C_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. Reproducible: Always See other bugs like https://bugs.gentoo.org/show_bug.cgi?id=467280 (see comments from Nick Novikov)
Created attachment 346638 [details, diff] Rename json to json-c in configure.ac That is the problem: > The pkgconfig name has also changed from json to json-c. (form https://github.com/json-c/json-c/blob/master/ChangeLog) This patch will replace PKG_CHECK_MODULES([JSON_C], [json]) with PKG_CHECK_MODULES([JSON_C], [json-c]) in configure.ac within src_prepare() in the ebuild so that rsyslog is able to build again with the new json-c.
(With that patch alone, the ebuild would start to fail against older json-c versions.)
Created attachment 346664 [details, diff] Check for json-c if json was not found You are right. The new patch will use the old json when available, if not it will use PKG_CHECK_MODULES's action-if-not-found to check for the new json-c (inspired by http://www.flameeyes.eu/autotools-mythbuster/pkgconfig/pkg_check_modules.html).
Created attachment 346666 [details, diff] New ebuild to use the new patch This is a patch for the ebuild, to use the new added patch.
Would be nice if we could combine the existing rsyslog-7.2.5-json-c-pkgconfig.patch file with the new rsyslog-7.2.7-json-c-pkgconfig2.patch file, but I don't know how to do that.
Thanks. Committed + files/rsyslog-7.2.5-json-c-pkgconfig.patch: + Detect new json-c-0.11. Patch from Thomas D. <whissi@whissi.de>. Fixes bug + #467338 + http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/rsyslog/files/rsyslog-7.2.5-json-c-pkgconfig.patch?r1=1.1&r2=1.2 Waiting for maintainers to ACK the new patch so I can send it upstream
Thanks a lot everyone, I'm okay with this ofc.
Thanks. Tracking upstream now
I updated upstream bug with current patches. Still tracking.
Comment # 3 on bug 438 from Rainer Gerhards Thanks for your continued effort. I was now able to merge the patches without any problems. They will be released as part of 7.4.4 (soon). Merged upstream, bumped version with integrated support, closing. +*rsyslog-7.4.4 (10 Sep 2013) + + 10 Sep 2013; Ultrabug <ultrabug@gentoo.org> -rsyslog-5.8.11.ebuild, + -rsyslog-5.8.12.ebuild, -rsyslog-5.10.1.ebuild, -rsyslog-6.6.0.ebuild, + +rsyslog-7.4.4.ebuild, -files/5-stable/rsyslog.confd, + -files/5-stable/rsyslog.initd, -files/5-stable/rsyslog.logrotate, + -files/5-stable/rsyslog-gentoo.conf, -files/6-stable/rsyslog.confd, + -files/6-stable/rsyslog.initd, -files/6-stable/rsyslog.logrotate, + -files/6-stable/rsyslog-gentoo.conf, -files/6-stable/rsyslog6-zeromq.patch: + Version bump, fix #467338, work on #442706 for systemd support, drop old and + unsupported versions, cleanup +
