466340 – net-ftp/vsftpd: add systemd unit, move checkconfig() to /usr/libexec/vsftpd-checkconfig.sh

Bug 466340 - net-ftp/vsftpd: add systemd unit, move checkconfig() to /usr/libexec/vsftpd-checkconfig.sh

Summary: net-ftp/vsftpd: add systemd unit, move checkconfig() to /usr/libexec/vsftpd-c...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo's FTP Packages Maintainers

URL:	https://github.com/Sabayon/systemd-lo...
Whiteboard:
Keywords:	REVIEWED

Depends on:
Blocks:

Reported:	2013-04-18 10:34 UTC by Fabio Erculiani (RETIRED)
Modified:	2013-04-27 09:50 UTC (History)
CC List:	4 users (show)

See Also:	467410
Package list:
Runtime testing required:	---

Attachments
vsftpd init script diff (vsftpd-init.diff,1.73 KB, patch) 2013-04-18 10:35 UTC, Fabio Erculiani (RETIRED)	Details \| Diff
vsftpd ebuild diff (vsftpd-ebuild.diff,858 bytes, patch) 2013-04-18 10:35 UTC, Fabio Erculiani (RETIRED)	Details \| Diff
vsftpd systemd unit (vsftpd.service,218 bytes, text/plain) 2013-04-18 10:35 UTC, Fabio Erculiani (RETIRED)	Details
vsftpd-checkconfig.sh (vsftpd-checkconfig.sh,785 bytes, text/plain) 2013-04-20 12:16 UTC, Fabio Erculiani (RETIRED)	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:34:44 UTC

At URL I committed an ebuild that adds a working systemd unit for net-ftp/vsftpd.
I moved the checkconfig() part of the openrc init script to /usr/libexec/vsftpd-checkconfig.sh to be reusable by the systemd unit.

Please have a look at the attached diffs.

Reproducible: Always

Comment 1 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:35:05 UTC

Created attachment 345874 [details, diff]
vsftpd init script diff

Comment 2 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:35:20 UTC

Created attachment 345876 [details, diff]
vsftpd ebuild diff

Comment 3 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-18 10:35:49 UTC

Created attachment 345878 [details]
vsftpd systemd unit

Comment 4 Markos Chandras (RETIRED) gentoo-dev

2013-04-18 10:42:23 UTC

Patches look good to me. Feel free to commit them

Comment 5 Johan Bergström 2013-04-18 10:43:39 UTC

LGTM too

Comment 6 Markos Chandras (RETIRED) gentoo-dev

2013-04-20 12:05:42 UTC

The usr/libexec/vsftpd-checkconfig.sh is missing. Can we have that too?

Comment 7 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-20 12:16:11 UTC

Created attachment 346082 [details]
vsftpd-checkconfig.sh

It's on the overlay under FILESDIR however

Comment 8 Markos Chandras (RETIRED) gentoo-dev

2013-04-20 16:49:21 UTC

+*vsftpd-3.0.2-r1 (20 Apr 2013)
+
+  20 Apr 2013; Markos Chandras <hwoarang@gentoo.org> +vsftpd-3.0.2-r1.ebuild,
+  +files/vsftpd-3.0.2-remove-legacy-cap.patch, +files/vsftpd.service,
+  +files/vsftpd-checkconfig.sh, files/vsftpd.init:
+  Add systemd unit file. Bug #466340 thanks to Fabio Erculiani
+  <lxnay@gentoo.org>. Add patch to remove legacy capabilities by
+  Joakim Tjernlund <Joakim.Tjernlund@transmode.se>. Bug #450536
+

Comment 9 Fabio Erculiani (RETIRED) gentoo-dev

2013-04-20 16:52:21 UTC

Thanks!