png.h used to #include <string.h> and it looks like gdk-pixbuf mistakenly relied on it i wouldn't have filed this otherwise but the package is important enough and the reason is known io-png.c:851:24: warning: implicit declaration of function 'strncmp' [-Wimplicit-function-declaration] io-png.c:853:32: warning: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] io-png.c:873:24: warning: implicit declaration of function 'strcmp' [-Wimplicit-function-declaration] io-png.c:853:46: warning: incompatible implicit declaration of built-in function 'strlen' [enabled by default] io-png.c:944:58: warning: incompatible implicit declaration of built-in function 'strlen' [enabled by default]
Created attachment 345648 [details, diff] gdk-pixbuf-2.28.0-string_h.patch
I see... https://git.gnome.org/browse/gdk-pixbuf/commit/?id=829379cfa2b48e966125df2d070d2af40cb3f990 But still no string.h at... https://git.gnome.org/browse/gdk-pixbuf/tree/gdk-pixbuf/io-png.c
Upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=698093
01:45 < EvaSDK> oh if it's trivial and backward tralala, feel free to commit :) + 15 Apr 2013; Samuli Suominen <ssuominen@gentoo.org> gdk-pixbuf-2.28.0.ebuild, + +files/gdk-pixbuf-2.28.0-string_h.patch: + Fix missing include string.h in gdk-pixbuf/io-png.c for strcmp, strlen and + strncmp (revealed by the libpng16 upgrade) wrt #466034 +
