Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465478 - =media-video/cinelerra-20120707: missing headers stdlib.h, string.h and strings.h (part of it after upgrading to libpng16)
Summary: =media-video/cinelerra-20120707: missing headers stdlib.h, string.h and strin...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: libpng16
  Show dependency tree
 
Reported: 2013-04-11 08:31 UTC by Martin von Gagern
Modified: 2013-04-11 09:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,2.28 KB, text/plain)
2013-04-11 08:31 UTC, Martin von Gagern
Details
Proposed fix (gentoo465478a.patch,749 bytes, patch)
2013-04-11 08:47 UTC, Martin von Gagern
Details | Diff
build log (media-video:cinelerra-20120707:20130410-170702.log,955.38 KB, text/plain)
2013-04-11 08:51 UTC, Martin von Gagern
Details
The patch that went in Portage (cinelerra-std_and_str_h.patch,1.61 KB, patch)
2013-04-11 09:11 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2013-04-11 08:31:45 UTC
Created attachment 345180 [details]
build log

cinelerra fails to remerge (after libpng upgrade) due to missing include statements:

vdevicebuz.C: In member function ‘void VDeviceBUZInput::start()’:
vdevicebuz.C:100:48: error: ‘bzero’ was not declared in this scope

SImilar error messages for strcpy, memcpy, bcopy, strerror.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2013-04-11 08:42:50 UTC
Comment on attachment 345180 [details]
build log

This build.log is not verbose. Useless.
Comment 2 Martin von Gagern 2013-04-11 08:47:30 UTC
Created attachment 345182 [details, diff]
Proposed fix
Comment 3 Martin von Gagern 2013-04-11 08:51:38 UTC
Created attachment 345184 [details]
build log

Seems I got the wrong build log last time around, this one here is the one I meant.
Comment 4 Martin von Gagern 2013-04-11 08:56:32 UTC
Note that the libpng upgrade is the one upgrade which made rebuilding cinelerra neccessary. But it was not the only upgrade, and it might well be that some other library used to include these headers in the past but no longer does so now. Also note that <string.h> and <strings.h> are different files, and the latter apparently is the one providing bzero and bcopy. My fix from comment #2 makes cinelerra compile all right for me, despite a million warnings about string literals getting assigned to non-const char*…
Comment 5 Martin von Gagern 2013-04-11 09:00:57 UTC
For those who DO NOT encounter this issue here, it would be interesting to run the vdevicebuz.C source through the preprocessor in order to find out which other headers cause the inclusion of the requires string.h and strings.h That would tell us what upgrade introduced this issue here.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2013-04-11 09:03:49 UTC
libpng 1.6 dropped the usage of string.h from it's headers... so most of these are at least related to the upgrade

similar bugs have been fixed around the tree, ffmpegthumbnailer, lensfun, etc
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2013-04-11 09:11:10 UTC
Created attachment 345190 [details, diff]
The patch that went in Portage

This is the patch I've used, based on your patch