First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 46544
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Mozilla Gentoo Team <mozilla@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Mike Auty <ikelos@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
mozilla-launcher-1.2.patch Fixes mozilla-launcher to include rudimentry thunderbird support patch Mike Auty 2004-04-01 17:15 0000 1.52 KB Details | Diff
mozilla-launcher-1.2-patch2.patch Updated patch to fix $u evaluation problem patch Mike Auty 2004-04-01 17:42 0000 1.53 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 46544 depends on: Show dependency tree
Bug 46544 blocks: 45367
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2004-04-01 17:09 0000
The new mozilla-launcher package, could be adapted to support starting
mozilla-thunderbird also.  This also would automatically add support for
detecting running instances of thunderbird, solving bug 45367.  It would also
unify all mozilla startup scripts, and make centralized changes to
mozilla-xremote-client easy to fix.

------- Comment #1 From Mike Auty 2004-04-01 17:15:11 0000 -------
Created an attachment (id=28541) [edit]
Fixes mozilla-launcher to include rudimentry thunderbird support

Attached is a patch that adds rudimentary thunderbird support.	Note that it
will open a new thunderbird window, or attempt to raise the existing one.

This hasn't been tested over multiple desktops (in fact, I'm not sure how that
ought to work, so I'll let someone else figure it out).

It also does not yet handle URLs, so thunderbird junk@yahoo.com simply ignores
the address.

It may also break running mozillas with multiple URLs because $u may get
evaluated in the which_browser function, rather than when it is intended to be
used.  I don't know enough bash scripting to help me delay it's evaluation. 
Any help would be appreciated.

Finally this also includes a small workaround for mozilla programs, in that it
removes the space between the comma and the new-{$newtype} command.  This is a
bug in mozilla, and is documented as Mozillabug 229681.  It seems to have gone
unnoticed by the mozilla developers, if anyone can bring it to their attention
that would also be nice.  5:)

------- Comment #2 From Mike Auty 2004-04-01 17:18:04 0000 -------
Sorry, I just realised the patch may not apply cleanly to the original version
of mozilla-launcher because I had already included the workaround for
mozillabug 229681 when I made the diff.  Sorry about that.  It should be easy
to see how to rectify it, so it does apply cleanly.

------- Comment #3 From Mike Auty 2004-04-01 17:42:26 0000 -------
Created an attachment (id=28543) [edit]
Updated patch to fix $u evaluation problem

Fixed patch that now applies directly to original mozilla-launcher-1.2, and
includes a fix to ensure that the $u term is evalutated when needed, not during
which_browser.	Figured I didn't need to do the same for new-type since that
gets set once at the top and doesn't get changed.

------- Comment #4 From Aron Griffis (RETIRED) 2004-04-01 20:50:48 0000 -------
Thanks Mike.  I wrote mozilla-launcher, but I haven't used thunderbird before. 
I'll take a look at your suggestions and hopefully get something out soon.

------- Comment #5 From Radoslaw Szkodzinski 2004-04-09 18:25:46 0000 -------
Seems I've done some redundant work:

Could you also make Thunderbird handle multiple mailto's,
like I did in my modified script?

I haven't done it in an universal way, but... it works.

------- Comment #6 From Aron Griffis (RETIRED) 2004-04-26 08:28:55 0000 -------
Sorry I haven't gotten to this yet, I hope to soon

------- Comment #7 From Aron Griffis (RETIRED) 2004-05-04 13:44:27 0000 -------
Thanks guys.  All set in thunderbird-0.6-r1 and mozilla-launcher-1.6

First Last Prev Next    No search results available      Search page      Enter new bug