Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465406 - net-libs/webkit-gtk - Don't check for sufficient debugging space if user passes -g0 (= no debugging info).
Summary: net-libs/webkit-gtk - Don't check for sufficient debugging space if user pass...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2013-04-10 16:04 UTC by Tom Wijsman (TomWij) (RETIRED)
Modified: 2013-05-01 12:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-10 16:04:35 UTC
See http://forums.gentoo.org/viewtopic-t-956634.html for details.
Comment 1 Pacho Ramos gentoo-dev 2013-04-27 10:27:12 UTC
If you have some suggestion to update the check and cover this case, please post it (not sure how many values can -gX have)
Comment 2 Agostino Sarubbo gentoo-dev 2013-04-30 12:05:35 UTC
I'd suggest to change:

-if [[ ${MERGE_TYPE} != "binary" ]] && is-flagq "-g*" ; then
+if [[ ${MERGE_TYPE} != "binary" ]] && is-flagq "-g*" && ! is-flagq "-g*0" ; then

Since we have a lot of -g* flags for the debug, in this manner we are sure that it is here to negate the debug like -g0

What do you think?
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-05-01 03:41:20 UTC
(In reply to comment #2)
> What do you think?

Good idea!

+  01 May 2013; Alexandre Rostovtsev <tetromino@gentoo.org>
+  webkit-gtk-1.8.3-r200.ebuild, webkit-gtk-1.8.3-r201.ebuild,
+  webkit-gtk-1.8.3-r300.ebuild, webkit-gtk-1.10.2-r300.ebuild,
+  webkit-gtk-2.0.0.ebuild, webkit-gtk-2.0.1.ebuild:
+  Don't treat -g0 as a debugging flag (bug #465406, thanks to Tom Wijsman and
+  Agostino Sarubbo).
Comment 4 Agostino Sarubbo gentoo-dev 2013-05-01 12:24:30 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > What do you think?
> 
> Good idea!

I just need to point another fact.

in case like: CFLAGS="-g0 -g" emerge foo, gcc will see the last declaration of -g, so it will add the debug symbols.

In case of this pkg_pretend(), CFLAGS="-g0 -g" the check will not done because of the presence of -g0


Obviously declare "-g0 -g" is a sort of non-sense but it may happen.