Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465380 - app-arch/sharutils-4.13.4: uudecode introduces incorrect newlines into its output.
Summary: app-arch/sharutils-4.13.4: uudecode introduces incorrect newlines into its ou...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://thread.gmane.org/gmane.comp.gn...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-04-10 09:44 UTC by Martin von Gagern
Modified: 2013-04-13 07:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Example input (Test1.uue,457 bytes, text/plain)
2013-04-10 09:44 UTC, Martin von Gagern
Details
Proposed fix (gentoo465380a.patch,669 bytes, patch)
2013-04-10 12:26 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2013-04-10 09:44:16 UTC
Created attachment 345102 [details]
Example input

The attached example comes from the configure script of dev-lang/swi-prolog-6.3.13. If decoded correctly, it will result in an executable Java class file of 311 bytes. app-arch/sharutils-4.13.4 will instead create a file of 318 bytes, with extra '\n' introduced in various places, thus breaking the file format.

As the issue appears to be fixed in current git HEAD, I assume that the removal of the TRY_PUTCHAR line in http://git.savannah.gnu.org/cgit/sharutils.git/diff/src/uudecode.c?id=262472c10eef9d12660934be8fe509040aac7965 is the fix. In that case the issue was introduced by http://git.savannah.gnu.org/cgit/sharutils.git/diff/src/uudecode.c?id=3e286f0822bce050a22ed3d8f9d9478600575479 which apparently is a commit AFTER the 4.13.3 release, so this is a regression and 4.13.3 is fine.
Comment 1 Martin von Gagern 2013-04-10 12:26:06 UTC
Created attachment 345118 [details, diff]
Proposed fix

I can confirm that removing the TRY_PUTCHAR line in question fixes this issue. I therefore suggest revbumping the ebuild and including the attached patch. I also contacted upstream via the bug-gnu-utils mailing list, suggesting a release including this fix, but so far my message is apparently still awaiting moderation.
Comment 2 Paul Bredbury 2013-04-11 06:47:16 UTC
Interestingly, db 4.8.30 runs uudecode in its ./configure, which never used to produce correct output.

uudecode from sharutils 4.13.4 is bad for this, as usual.
uudecode from sharutils 4.13.3 produces *correct* output.

So, I kinda confirm ;)
Comment 3 Bruce Korb 2013-04-11 15:17:03 UTC
I bit off too much and I'm going to be away for two weeks, so a released fix won't happen until May.  Until then, please either drop back or pull from the repo.  Thank you.
Comment 4 Bruce Korb 2013-04-11 16:47:30 UTC
Alternatively:  http://autogen.sourceforge.net/data/sharutils-4.13.5pre4.tar.xz
Comment 5 SpanKY gentoo-dev 2013-04-11 17:48:39 UTC
(In reply to comment #4)

i think we can wait for 4.13.5.  i doubt this impacts many people ;).
Comment 6 Tim Harder gentoo-dev 2013-04-13 07:50:15 UTC
4.13.5 added to CVS.