465292 – sci-libs/armadillo-3.4.4 calls tc-getPKGCONFIG instead of tc-getPKG_CONFIG

Bug 465292 - sci-libs/armadillo-3.4.4 calls tc-getPKGCONFIG instead of tc-getPKG_CONFIG

Summary: sci-libs/armadillo-3.4.4 calls tc-getPKGCONFIG instead of tc-getPKG_CONFIG

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Science Related Packages

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2013-04-09 16:56 UTC by James Cline
Modified:	2013-04-10 06:05 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Corrected ebuild (armadillo-3.4.4.ebuild,1.24 KB, text/plain) 2013-04-09 16:56 UTC, James Cline	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Cline 2013-04-09 16:56:13 UTC

The ebuild is calling tc-getPKGCONFIG instead of tc-getPKG_CONFIG. This is fixed in the masked ebuilds (3.6.x).

This results in projects linking against armadillo to also have to explicitly link against blas and lapack (by default, armadillo wraps this for you), but since it cannot find those libraries due to this typo that is broken. 

I've attached a corrected version of the ebuild.

Comment 1 James Cline 2013-04-09 16:56:33 UTC

Created attachment 345010 [details]
Corrected ebuild

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2013-04-09 17:56:28 UTC

Comment on attachment 345010 [details]
Corrected ebuild

--- armadillo-3.4.4.ebuild      2013-01-07 04:06:51.178921766 +0100
+++ -   2013-04-09 19:56:22.032022482 +0200
@@ -35,13 +35,13 @@
        if use blas; then
                mycmakeargs+=(
                        -DBLAS_FOUND=ON
-                       -DBLAS_LIBRARIES="$($(tc-getPKGCONFIG) --libs blas)"
+                       -DBLAS_LIBRARIES="$($(tc-getPKG_CONFIG) --libs blas)"
                )
        fi
        if use lapack; then
                mycmakeargs+=(
                        -DLAPACK_FOUND=ON
-                       -DLAPACK_LIBRARIES="$($(tc-getPKGCONFIG) --libs lapack)"
+                       -DLAPACK_LIBRARIES="$($(tc-getPKG_CONFIG) --libs lapack)"
                )
        fi
        cmake-utils_src_configure

Comment 3 Justin Lecher (RETIRED) gentoo-dev

2013-04-10 06:05:00 UTC

  10 Apr 2013; Justin Lecher <jlec@gentoo.org> armadillo-3.4.4.ebuild,
  metadata.xml:
  Fix typo for pkg-config, #465292