Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465130 - www-client/firefox-bin - install bigger app icons
Summary: www-client/firefox-bin - install bigger app icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-08 16:33 UTC by Frank Steinmetzger
Modified: 2014-06-18 11:02 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Steinmetzger 2013-04-08 16:33:34 UTC
The ebuild for firefox-bin currently installs a 48x48 pixel icon from chrome/icons/default/default48.png into /usr/share/pixmaps/firefox-bin-icon.png. I would like to ask whether a bigger icon could be used. The binary archive even ships with one, at icons/mozicon128.png.

The reason is that nowadays, icons in desktop environments become ever bigger, and a 48x48 icons appears lost between the other, much bigger ones, for example in KDE’s Alt-Tab task switcher.

Thanks for your consideration.

Reproducible: Always
Comment 1 Rick Farina (Zero_Chaos) gentoo-dev 2013-04-09 16:17:27 UTC
+  09 Apr 2013; Rick Farina <zerochaos@gentoo.org> +firefox-bin-20.0-r2.ebuild:
+  after discussing with maintainer here is my attempt at a fix for bug 465130,
+  hope everyone likes it


I'm shipping the icons in a very similar style to the way the normal firefox ebuild does it now.  Does this meet your needs? If not please reopen with details.

Thanks for the request!
Comment 2 Frank Steinmetzger 2013-12-27 13:21:26 UTC
Sorry to disappoint, but I have to reopen (after a long time of not bothering with it).

The icon appears small [again(?)]. I looked at how Arch is doing it, since there it works as requested. They install icons only into /usr/share/icons/hicolor/*, from 16x16 all the way through to 256x256.

According to bug #359175, /usr/share/pixmap is deprecated. Maybe the pixmaps icon gets precedence over hicolor. So the easiest thing would be to simply not install into pixmaps.
Comment 3 Frank Steinmetzger 2014-05-09 16:51:13 UTC
I was researching this again last week. After some trial and error I finally got my KDE to show big icons. During my attempts I created icon sets in hicolor with files called firefox.png, firefox-bin.png and firefox-bin-icon.png. I don’t know for sure what did the trick in the end. I suspect now the following line in the .desktop file to be the cause:

ICON=firefox-bin-icon

while the actual icon files in /usr/share/icons/hicolor are named firefox-bin. So I reckon that since they are not found, the pixmap is used as fallback. 
I tried to confirm this theory by deleting the firefox-bin-icon.png files, logged out of KDE, cleared my KDE cache and logged back in, but the icon was still large. There must be something intervening in the inner works of KDE.
Comment 4 Pacho Ramos gentoo-dev 2014-05-25 16:24:01 UTC
Indeed, pixmaps icon takes precedence. Why are we shipping it? hicolors icons would be enough

Thanks
Comment 5 Frank Steinmetzger 2014-05-25 19:39:05 UTC
Interestingly, blender 2.70 installs hicolor icons up to 256×256 and *none* into pixmaps, and it also is only show with a small icon in KDE’s app switcher. So I’m out of logic. :-/
Comment 6 Pacho Ramos gentoo-dev 2014-06-15 16:22:51 UTC
I have seen icons are named in two ways:
/usr/share/icons/hicolor/*/apps/firefox-bin.png
/usr/share/pixmaps/firefox-bin-icon.png

But .desktop file is forced to use pixmaps icon as it states:
Icon=firefox-bin-icon

Per:
https://developer.gnome.org/icon-theme-spec/

"By default, apps should look in $HOME/.icons (for backwards compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order)."

Then, this should be solved renaming all icons to the same name and app should take the best icon. I would rename all to firefox-bin.png and make the desktop look for it.
Comment 7 Pacho Ramos gentoo-dev 2014-06-15 16:38:35 UTC
And, indeed, it fixes the problem \o/, I can commit the changes if you prefer ;)
Comment 8 Jory A. Pratt gentoo-dev 2014-06-15 20:37:33 UTC
(In reply to Pacho Ramos from comment #7)
> And, indeed, it fixes the problem \o/, I can commit the changes if you
> prefer ;)

commit it when you have a chance please.
Comment 9 Pacho Ramos gentoo-dev 2014-06-16 08:53:55 UTC
+  16 Jun 2014; Pacho Ramos <pacho@gentoo.org> files/firefox-bin.desktop,
+  firefox-bin-17.0.10.ebuild, firefox-bin-17.0.9.ebuild,
+  firefox-bin-24.5.0.ebuild, firefox-bin-24.6.0.ebuild, firefox-bin-30.0.ebuild:
+  Allow bigger icon to be used (#465130)
+
Comment 10 Frank Steinmetzger 2014-06-18 11:02:53 UTC
I removed all firefox icons from /usr/share/icons/hicolor, including my manual modifications, logged out of KDE and ran kbuildsycoca --noincremental on a console.
I logged back in and opened firefox -- the big 128×128 icon was still shown when pressing alt-tab. Then I synced portage and reinstalled firefox-bin. I hate to be a party pooper, but now the icon is displayed at 48×48 again. I guess it's not the fault of the firefox ebuild though, rather something in KDE seems wrong. I will try and take it up with them. Thanks for the effort anyway.