Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465108 - media-tv/xbmc - make more addons optional
Summary: media-tv/xbmc - make more addons optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Xbox project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-04-08 14:28 UTC by hal
Modified: 2013-04-13 19:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Remove unneeded addons (remove-unneeded-addons.patch,1.40 KB, patch)
2013-04-08 14:28 UTC, hal
Details | Diff
Added optional addons into an array (optional-addons.patch,1009 bytes, patch)
2013-04-08 20:39 UTC, hal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hal 2013-04-08 14:28:10 UTC
Created attachment 344844 [details, diff]
Remove unneeded addons

If one wants to build xbmc with USE="-goom -fishbmc -projectm -rsxs" it is still possible to select the addons in the visualization and screensaver sections resulting in a crash of xbmc in cases when one selects the specific addon and it gets activated.

I'd expect plugins to not appear in the GUI at all if I didn't built them.

Attached is a patch which removes these addons. Additionally I added some paths to addons which are made for Android, Windows and OS X.
Comment 1 SpanKY gentoo-dev 2013-04-08 19:48:25 UTC
Comment on attachment 344844 [details, diff]
Remove unneeded addons

create an array instead and do a single rm

local disabled_addons=(
  repository.pvr-{android,ios,osx{32,64},win32}.xbmc.org
  visualization.dxspectrum
)
use rsxs || disabled_addons+=( screensaver.rsxs.{euphoria,plasma,....}
rm -rf "${disabled_addons[@]/#/${ED}/usr/share/xbmc/addons/}"
Comment 2 hal 2013-04-08 20:39:28 UTC
Created attachment 344884 [details, diff]
Added optional addons into an array

Good hint, looks better now.
Comment 3 SpanKY gentoo-dev 2013-04-13 19:22:31 UTC
Patch by hal to punt unused addons
http://sources.gentoo.org/media-tv/xbmc/xbmc-9999.ebuild?r1=1.139&r2=1.140