Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465044 - x11-libs/cairo - OOM fix for usage with libpng-1.6
Summary: x11-libs/cairo - OOM fix for usage with libpng-1.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben de Groot (RETIRED)
URL: https://bugs.freedesktop.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks: libpng16
  Show dependency tree
 
Reported: 2013-04-08 08:14 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2013-04-27 05:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-04-08 08:14:37 UTC
See URL. Dunno if we need this patch. I just want to point your attention on it.
Comment 1 Richard Grenville 2013-04-10 03:54:08 UTC
After update to media-libs/libpng-1.6.1 and rebuild cairo with it, I found app-i18n/fcitx-4.2.7 crashing with SIGSEGV. Further inspection reveals fcitx is trying to read a PNG image with cairo_image_surface_create_from_png() (fcitx-4.2.7/src/ui/classic/InputWindow.c:69 -> fcitx-4.2.7/src/ui/classic/skin.c:240), then checks if the returned cairo surface has an error. After upgrading to libpng-1.6.1, cairo started failing to read the PNG image with CAIRO_STATUS_NO_MEMORY. When there are an error, fcitx frees the surface and return NULL, yet it later doesn't handling this NULL pointer gracefully and segfaults. Applying the patch in the FreeDesktop bug report to x11-libs/cairo-1.12.12-r1 fixes the issue immediately. So, just to confirm here that the problem does exists and the patch is useful indeed.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-04-11 05:20:45 UTC
+*cairo-1.12.14 (11 Apr 2013)
+
+  11 Apr 2013; Lars Wendler <polynomial-c@gentoo.org>
+  +files/cairo-libpng16.patch, +cairo-1.12.14.ebuild:
+  Non-maintainer commit: Version bump (bug #456818). Added libpng16 patch (bug
+  #465044). Committed with kind permission from yngwin.
+