Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464996 - x11-libs/vte:0 port to python-r1
Summary: x11-libs/vte:0 port to python-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 464998
  Show dependency tree
 
Reported: 2013-04-07 18:50 UTC by Julian Ospald
Modified: 2013-04-07 21:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vte-0.28.2-r205.ebuild.patch (vte-0.28.2-r205.ebuild.patch,1.92 KB, patch)
2013-04-07 18:50 UTC, Julian Ospald
Details | Diff
vte-0.28.2-r205.ebuild.diff (vte-0.28.2-r205.ebuild.diff,2.07 KB, patch)
2013-04-07 19:12 UTC, Julian Ospald
Details | Diff
vte-0.28.2-r205.ebuild.diff (vte-0.28.2-r205.ebuild.diff,2.08 KB, patch)
2013-04-07 19:13 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-04-07 18:50:21 UTC
Created attachment 344742 [details, diff]
vte-0.28.2-r205.ebuild.patch

Tested with dev-util/a8, works.

pyvte.pc does not seem to have any python-version specific information, so that can be ignored for now
Comment 1 Julian Ospald 2013-04-07 19:12:04 UTC
Created attachment 344746 [details, diff]
vte-0.28.2-r205.ebuild.diff

don't run python_foreach_impl unconditionally, rather wrap the phases depending on python useflag, thanks to mgorny
Comment 2 Julian Ospald 2013-04-07 19:13:58 UTC
Created attachment 344748 [details, diff]
vte-0.28.2-r205.ebuild.diff

I missed one.
Comment 3 Pacho Ramos gentoo-dev 2013-04-07 19:18:37 UTC
+*vte-0.28.2-r205 (07 Apr 2013)
+
+  07 Apr 2013; Pacho Ramos <pacho@gentoo.org> +vte-0.28.2-r205.ebuild,
+  -vte-0.34.1.ebuild:
+  Move to python-r1 (#464996 by Julian Ospald), drop old.
+
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-04-07 20:36:32 UTC
Reopening since the ebuild needs to be fixed. Multi-impl support must not be enforced at any cost, and especially not in cost of serious QA violations. And repeatedly building the whole vte and discarding n-1 builds of is one of the kind.

Looking at it, I doubt there's a clear way of building for multiple impls without heavy hackery which is simply not worth the effort. I'd just go for python-single-r1 here, and python-single-r1 all the deps.


To use multi-impl support, you would have to:

1) do some conditional building and ugly-symlinking

Build the whole thing for one impl, then symlink .la and libs to others and 'emake -C python' there. That's just ugly, and hard to achieve. You'd have to hack autotools a fair bit.

2) build all the impls in the same dir (untested)

Theoretically you could just build all the impls one by one. Then the common parts will not be rebuilt, but you'd have to hack it hard to have split python parts and more to switch the Python impls. Just don't do this.
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-04-07 20:43:19 UTC
It was done properly in a couple of ebuilds already, see gtk-vnc for example. It just needs a bit more care than usual.
Comment 6 Julian Ospald 2013-04-07 21:38:21 UTC
+*vte-0.28.2-r206 (07 Apr 2013)
+
+  07 Apr 2013; Julian Ospald <hasufell@gentoo.org> -vte-0.28.2-r205.ebuild,
+  +vte-0.28.2-r206.ebuild:
+  revise python logic to avoid rebuilding non-python parts