464716 – dev-ruby/json does not respect CFLAGS="-O?"

Bug 464716 - dev-ruby/json does not respect CFLAGS="-O?"

Summary: dev-ruby/json does not respect CFLAGS="-O?"

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Ruby Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-04-05 11:18 UTC by Agostino Sarubbo
Modified:	2013-04-09 17:38 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Agostino Sarubbo gentoo-dev

2013-04-05 11:18:06 UTC

You receive this bug because this package does not respect my '-O' system's CFLAGS


x86_64-pc-linux-gnu-gcc -I. -I/usr/lib64/ruby/1.8/x86_64-linux -I/usr/lib64/ruby/1.8/x86_64-linux -I. -DJSON_GENERATOR    -fPIC -march=native -O3 -g0 -pipe 
-fno-strict-aliasing  -fPIC  -Wall -O0 -ggdb  -c generator.c

Please also drop -ggdb

Comment 1 Thierry De Leeuw 2013-04-07 14:00:50 UTC

Also note that it looks like the following line 
ext/json/ext/parser/extconf.rb:unless $CFLAGS.gsub!(/ -O[\dsz]?/, ' -O3')
gives stange result when used with -Ofast (it results in -O3fast, which prevents compilation with error cc1: error: invalid option argument ‘-O3fast’)

Comment 2 Hans de Graaff gentoo-dev

2013-04-09 17:38:58 UTC

Fixed in json 1.7.7-r1.

I've dropped all the CFLAGS hoopla except -Wall.