Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464358 - net-misc/cfengine-3.4.4 wrongly reports "Regular expression error" with edit_template and insert_lines
Summary: net-misc/cfengine-3.4.4 wrongly reports "Regular expression error" with edit_...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Marc Schiffbauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 13:51 UTC by Andreas Prieß
Modified: 2014-02-27 17:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,19.21 KB, text/plain)
2013-04-03 13:53 UTC, Andreas Prieß
Details
Test case with promises for CFEngine (test.cf,688 bytes, text/plain)
2013-04-03 13:55 UTC, Andreas Prieß
Details
Template file for the test case (cfe-test.template,324 bytes, text/plain)
2013-04-03 13:56 UTC, Andreas Prieß
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Prieß 2013-04-03 13:51:49 UTC
After update from CFEngine 3.3.9 to 3.4.4 errors are reported for regular expressions at places that should NOT be parsed as regular expression in the first place.

This happens with promises using edit_template and insert_lines.

A simple test case will be attached.

This and similar problems are reported in the CFEngine bug tracker:
https://cfengine.com/dev/issues/1986
https://cfengine.com/dev/issues/1837
https://cfengine.com/dev/issues/1897

https://cfengine.com/dev/issues/2083
https://cfengine.com/dev/issues/1820
https://cfengine.com/dev/issues/1865

It seems the promises are kept in all cases, so the files are created as expected, but there are always this error messages without a reason, making it difficult to see the real errors.

Reproducible: Always
Comment 1 Andreas Prieß 2013-04-03 13:53:56 UTC
Created attachment 344224 [details]
emerge --info
Comment 2 Andreas Prieß 2013-04-03 13:55:47 UTC
Created attachment 344226 [details]
Test case with promises for CFEngine
Comment 3 Andreas Prieß 2013-04-03 13:56:16 UTC
Created attachment 344228 [details]
Template file for the test case
Comment 4 Andreas Prieß 2013-04-03 14:00:41 UTC
Having the test case as /tmp/test.cf and the template as /tmp/cfe-test.template the problem can be reproduced with:

/usr/sbin/cf-agent --no-lock --file /tmp/test.cf

Regular expression error "range out of order in character class" in expression "# This should be a comment without any expansions. [but this will give an error: mysql-5.1]!" at 87
Regular expression error "range out of order in character class" in expression "[This is ok? No: php-5.3.ini or so...]" at 21
Regular expression error "nothing to repeat" in expression "* also found in CFE-Bug#1820" at 0
Regular expression error "unmatched parentheses" in expression "And parenthesis ) are also a problem, at least single ones. I have them in security related strings like salts and encryption keys." at 16
R: CFE test ok
Comment 5 Andreas Prieß 2013-04-15 10:21:46 UTC
The upstream bugs #1897 and #2083 have been closed, so this should be fixed in the next 3.4.x release.
Comment 6 Christian Ruppert (idl0r) gentoo-dev 2014-02-22 14:44:37 UTC
Re-assign to the new maintainer.
Comment 7 Marc Schiffbauer gentoo-dev 2014-02-22 23:32:14 UTC
I bumped 3.4.4 to 3.4.5 is this fixed for you  now?
Comment 8 Andreas Prieß 2014-02-26 20:23:10 UTC
Unfortunately net-misc/cfengine-3.4.5 does _not_ fix this issue, same errors as before.

Seems the fix did not go into the 3.4.x version.

Comment #20 here
https://cfengine.com/dev/issues/2083#note-20
tells us:
"Right now this commit lives in the master branch and so would more naturally lend itself to a 3.5.x release."

So hopefully a later version will have this fixed.
Comment 9 Marc Schiffbauer gentoo-dev 2014-02-27 17:50:20 UTC
Version 3.5.3 now in tree, so the issue should be fixed there, right?

Please repoen if something is wrong...