Bug 464118 – net-analyzer/wireshark shouldn't check for compiler version unconditionally in pkg_pretend

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sławomir Nizio 2013-04-01 18:56:53 UTC]

Wireshark ebuilds use gcc-major-version and gcc-minor-version in pkg_pretend and abort if reported version is too old. This check should be unnecessary for binary packages and breaks them when gcc is not installed or too old.

If possible, please change it. Some ideas:
a) do the check if not merging from binary package,
b) move it to a different phase.

Reproducible: Always

[Comment 1 Julian Ospald 2013-04-01 19:30:18 UTC]

	if [[ ${MERGE_TYPE} != binary ]]; then

[Comment 2 Julian Ospald 2013-04-01 19:32:53 UTC]

maybe even:

if [[ ${MERGE_TYPE} != binary ]]; then
	if [[ $(tc-getCC) =~ gcc ]]; then

[Comment 3 Julian Ospald 2013-04-01 19:33:25 UTC]

oops, that was bash-4.2, use: [[ $(tc-getCC) == *gcc* ]]

[Comment 4 Sławomir Nizio 2013-04-01 19:53:16 UTC]

fi
fi
fi

(In reply to comment #3)
> oops, that was bash-4.2, use: [[ $(tc-getCC) == *gcc* ]]

=~ exists in bash 3 too :)

[Comment 5 Sławomir Nizio 2013-04-01 19:53:42 UTC]

btw. nice idea I think

[Comment 6 Jeroen Roovers (RETIRED) 2013-04-02 19:44:26 UTC]

I'm in the process of removing the entire pkg_pretend and checking to see what breaks...

[Comment 7 Jeroen Roovers (RETIRED) 2013-04-02 21:05:23 UTC]

I removed pkg_pretend() from all ebuilds.

[Comment 8 Sławomir Nizio 2013-04-03 17:35:14 UTC]

Thanks!