Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464092 - sci-visualization/gnuplot-4.6.2-r1 - ./gnuplot.texi:17653: raising the section level of @subsubsection which is too low (with sys-apps/texinfo-5.1)
Summary: sci-visualization/gnuplot-4.6.2-r1 - ./gnuplot.texi:17653: raising the sectio...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Ulrich Müller
URL: http://sourceforge.net/p/gnuplot/bugs...
Whiteboard:
Keywords: PATCH
: 464504 (view as bug list)
Depends on:
Blocks: texinfo-5.1
  Show dependency tree
 
Reported: 2013-04-01 15:24 UTC by Andrés Becerra Sandoval
Modified: 2013-05-08 00:19 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (sci-visualization:gnuplot-4.6.2-r1:20130401-211459.log,138.00 KB, text/plain)
2013-04-02 06:52 UTC, Martin von Gagern
Details
Fix info source (gentoo464092a.patch,15.87 KB, patch)
2013-04-02 10:05 UTC, Martin von Gagern
Details | Diff
gnuplot-4.6.2-texinfo-5.patch (gnuplot-4.6.2-texinfo-5.patch,535 bytes, patch)
2013-04-02 21:16 UTC, Ulrich Müller
Details | Diff
gnuplot-4.6.2-r1.ebuild.patch (gnuplot-4.6.2-r1.ebuild.patch,1.20 KB, patch)
2013-04-23 00:40 UTC, cmuelle8
Details | Diff
gnuplot-4.6.3.ebuild.patch (gnuplot-4.6.3.ebuild.patch,1.16 KB, patch)
2013-04-23 00:41 UTC, cmuelle8
Details | Diff
gnuplot-4.6.2-r1-to-4.6.3.ebuilds.diff (gnuplot-4.6.2-r1-to-4.6.3.ebuilds.diff,1.06 KB, patch)
2013-04-23 00:44 UTC, cmuelle8
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrés Becerra Sandoval 2013-04-01 15:24:33 UTC
I get the following error:

make[1]: Leaving directory `/var/tmp/portage/sci-visualization/gnuplot-4.6.2-r1/work/gnuplot-4.6.2'
./gnuplot.texi:9205: warning: @ref should not appear in @uref
./gnuplot.texi:17653: raising the section level of @subsubsection which is too low
make[1]: *** [gnuplot.info] Error 1
make[1]: Leaving directory `/var/tmp/portage/sci-visualization/gnuplot-4.6.2-r1/work/gnuplot-4.6.2/docs'


emerge --info:


Portage 2.2.0_alpha170 (default/linux/amd64/13.0/desktop/kde, gcc-4.7.2, glibc-2.17, 3.8.5-gentoo x86_64)
=================================================================
System uname: Linux-3.8.5-gentoo-x86_64-AMD_Athlon-tm-_II_Neo_K325_Dual-Core_Processor-with-gentoo-2.2
KiB Mem:     1792956 total,    480444 free
KiB Swap:    1959892 total,   1901360 free
Timestamp of tree: Mon, 01 Apr 2013 14:30:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
app-shells/bash:          4.2_p45
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r1
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r3, 1.11.6, 1.13.1
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.2-r1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.8 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo local
Installed sets: @bio, @dicts, @gtk, @kdeadmin, @kdeapps, @kdeartwork, @kdebase, @kdegames, @kdegraphics, @kdemultimedia, @kdenetwork, @kdepim, @kdesdk, @kdetweaks, @kdeutils, @laptop, @networks, @qt4, @speech
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe -ggdb"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/polkit-1/actions /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=athlon64 -O2 -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync metadata-transfer news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.datapipe.net/gentoo http://www.gtlib.gatech.edu/pub/gentoo http://lug.mtu.edu/gentoo/"
LANG="es_CO.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 berkdb branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam firefox flac fortran gdbm gif gpm handbook iconv icu ipv6 jpeg kde kerberos kipi lcms ldap libnotify lm-sensors lzma mad mmx mng modules mp3 mp4 mpeg mudflap multilib ncurses nforce2 nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma pmu png policykit ppds pulseaudio qt3support qt4 readline samba sdl semantic-desktop session spell sse sse2 ssl startup-notification svg system-sqlite tcpd tiff truetype udev udisks unicode upower usb v4l2 vorbis x264 xcb xcomposite xinerama xml xscreensaver xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="es en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="vesa radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-01 23:32:14 UTC
Please attach the complete build log.
Comment 2 Martin von Gagern 2013-04-02 06:52:48 UTC
Created attachment 344038 [details]
build log

Same error here, build log attached.
This is almost certainly linked to the doc USE flag.
I'm a bit surprised that the process terminates although this error message does not appear fatal.
I recently updated texinfo from 4.13-r2 to 5.1. As I had gnuplot-4.6.2 installed before, this seems to be related to the texinfo upgrade.
Comment 3 Martin von Gagern 2013-04-02 10:05:02 UTC
Created attachment 344052 [details, diff]
Fix info source

This patch keeps texinfo 5.x happy. It omits the @ref inside the @uref, and raises all the terminal type sections from @subsubsection to @subsection level, as they are children of a @section, the "complete list of terminals". Emerged all right for me.
Comment 4 Juergen Rose 2013-04-02 13:05:15 UTC
Thanks Martin,

the patch works for me.
Comment 5 Andrés Becerra Sandoval 2013-04-02 19:48:31 UTC
(In reply to comment #1)
> Please attach the complete build log.

Martin did it first, is my same problem.

I have applied Martin's patch and emerged the package successfully.

Thanks!
Comment 6 Ulrich Müller gentoo-dev 2013-04-02 20:07:19 UTC
Can you please report this upstream, too?
Comment 7 Ulrich Müller gentoo-dev 2013-04-02 21:16:16 UTC
Created attachment 344122 [details, diff]
gnuplot-4.6.2-texinfo-5.patch

gnuplot.texi is a generated file, so the fix should really be applied to doc2texi.el, see attached patch.

OTOH, that would require Emacs as build-time dependency. We had that previously, and some people were unhappy with that (see bug 368269, bug 369097, bug 400999, and numerous duplicates). So maybe we should use Martin's patch in addition, so that gnuplot.texi doesn't need to be regenerated.

@Christoph: What is your opinion?
Comment 8 Christoph Junghans (RETIRED) gentoo-dev 2013-04-03 15:03:12 UTC
(In reply to comment #7)
> Created attachment 344122 [details, diff] [details, diff]
> gnuplot-4.6.2-texinfo-5.patch
> 
> gnuplot.texi is a generated file, so the fix should really be applied to
> doc2texi.el, see attached patch.
> 
> OTOH, that would require Emacs as build-time dependency. We had that
> previously, and some people were unhappy with that (see bug 368269, bug
> 369097, bug 400999, and numerous duplicates). So maybe we should use
> Martin's patch in addition, so that gnuplot.texi doesn't need to be
> regenerated.
> 
> @Christoph: What is your opinion?
I personally think gnuplot's build-in help is anyway the best way to find information and considering the fact that we had trouble with the texi generation before, let's just bundle a recent version and add a "noinfo" use flag.
Comment 9 Andrés Becerra Sandoval 2013-04-03 15:43:40 UTC
(In reply to comment #6)
> Can you please report this upstream, too?

It is reported already:

http://sourceforge.net/p/gnuplot/bugs/1226/
Comment 10 Ulrich Müller gentoo-dev 2013-04-03 16:15:52 UTC
(In reply to comment #8)
> I personally think gnuplot's build-in help is anyway the best way to find
> information and considering the fact that we had trouble with the texi
> generation before, let's just bundle a recent version and add a "noinfo" use
> flag.

Excellent idea. I've packed gnuplot.info (generated with makeinfo 4.13) in an extra tarball and uploaded it to Gentoo mirrors. The updated ebuild will follow soon.

I haven't added the noinfo flag though, as the additional distfile has less then 200 kbytes which is negligible.


(In reply to comment #9)
> > Can you please report this upstream, too?
> 
> It is reported already:
> 
> http://sourceforge.net/p/gnuplot/bugs/1226/

We can close the downstream bug then. Thanks for reporting!
Comment 11 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-04 15:49:26 UTC
*** Bug 464504 has been marked as a duplicate of this bug. ***
Comment 12 Martin von Gagern 2013-04-22 12:18:26 UTC
This problem is back in sci-visualization/gnuplot-4.6.3, due to the fact that the ebuild copies the old info file without touching its timestamp. Since gnuplot.info will end up being older than gnuplot.texi, make will still attempt to rebuild it, resulting in the described issues.
Comment 13 Martin von Gagern 2013-04-22 12:23:36 UTC
The patch from comment #3 can still be used to fix this, so even though the documentation is originally generated via doc2texi.el, as comment #7 states, the resulting gnuplot.texi is shipped with the package and can be used for patching. Personally I'd consider this approach better than the pre-compiled texinfo documents, since it is more source-oriented, more the Gentoo way to do this, and would avoid the burden of having to keep the info reasonably up to date.
Comment 14 Christoph Junghans (RETIRED) gentoo-dev 2013-04-22 17:06:10 UTC
(In reply to comment #13)
> The patch from comment #3 can still be used to fix this, so even though the
> documentation is originally generated via doc2texi.el, as comment #7 states,
> the resulting gnuplot.texi is shipped with the package and can be used for
> patching. Personally I'd consider this approach better than the pre-compiled
> texinfo documents, since it is more source-oriented, more the Gentoo way to
> do this, and would avoid the burden of having to keep the info reasonably up
> to date.
And I personally think, we should just get rid of this info file completely. Is your above patch still valid for 4.6.3 ?
Comment 15 Ulrich Müller gentoo-dev 2013-04-22 20:07:21 UTC
(In reply to comment #13)
> The patch from comment #3 can still be used to fix this, so even though the
> documentation is originally generated via doc2texi.el, as comment #7 states,
> the resulting gnuplot.texi is shipped with the package and can be used for
> patching. Personally I'd consider this approach better than the pre-compiled
> texinfo documents, since it is more source-oriented, more the Gentoo way to
> do this, and would avoid the burden of having to keep the info reasonably up
> to date.

The "Gentoo way" is what I've outlined in comment #7.


(In reply to comment #14)
> And I personally think, we should just get rid of this info file completely.
> Is your above patch still valid for 4.6.3 ?

Patching a generated file is not a proper solution. Also the patch is a bit large for FILESDIR, so we'd have to put it on mirrors.
Comment 16 cmuelle8 2013-04-22 20:37:21 UTC
(In reply to comment #15)
> Patching a generated file is not a proper solution. Also the patch is a bit
> large for FILESDIR, so we'd have to put it on mirrors.

535 bytes is quite large??  wow!  come on, if gentoo devs would have just fixed it like originally proposed, this discussion would long be over.

patching a distributed file is fine - it's a file from upstream.  e.g., we do not run eautoreconf all the time, unless necessary.


Greetings

btw: imho, for indeed larger patches, portage could just hold them gzipped or xz'd. and epatch shoul handle that just as well if it does not already.
Comment 17 Ulrich Müller gentoo-dev 2013-04-22 22:06:14 UTC
(In reply to comment #16)
> 535 bytes is quite large??  wow!  come on, if gentoo devs would have just
> fixed it like originally proposed, this discussion would long be over.

The patch for the texinfo file has 16 kB size which is close to the repoman limit. I'd rather not put it in filesdir.

Concerning the rest of your comment: Please read up on the relevant policies before posting.
Comment 18 cmuelle8 2013-04-22 23:10:28 UTC
(In reply to comment #17)
> The patch for the texinfo file has 16 kB size which is close to the repoman
> limit. I'd rather not put it in filesdir.

Ah, sorry - mixed this up with your own patch.  You did not go into why patches cannot be held zipped in portage.

Looking at the obsoleted patch there is a lot of repetition.  If we can find a regexp catching the subsubsections in question maybe a simple sed command will do and you won't have to care about any patch..

Greetings
your fellow policy reader ..
Comment 19 cmuelle8 2013-04-22 23:39:05 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > The patch for the texinfo file has 16 kB size which is close to the repoman
> > limit. I'd rather not put it in filesdir.
> 
> Ah, sorry - mixed this up with your own patch.  You did not go into why
> patches cannot be held zipped in portage.
> 
> Looking at the obsoleted patch there is a lot of repetition.  If we can find
> a regexp catching the subsubsections in question maybe a simple sed command
> will do and you won't have to care about any patch..

It will:

sed -e '/^@uref/ s/@ref{\([^}]*\)}/\1/' \
    -e '/^@node aed767/,$ s/^@sub/@/' \
    -i gnuplot.texi

I hope this is small enough for portage..

Greetings
Comment 20 cmuelle8 2013-04-23 00:40:43 UTC
Created attachment 346336 [details, diff]
gnuplot-4.6.2-r1.ebuild.patch
Comment 21 cmuelle8 2013-04-23 00:41:34 UTC
Created attachment 346338 [details, diff]
gnuplot-4.6.3.ebuild.patch
Comment 22 cmuelle8 2013-04-23 00:44:52 UTC
Created attachment 346340 [details, diff]
gnuplot-4.6.2-r1-to-4.6.3.ebuilds.diff

This is just a diff between the /patched/ ebuilds, i.e. the ones from portage with the attachment ebuild.patches of this bug applied, for reference.
Comment 23 cmuelle8 2013-05-08 00:19:36 UTC
This is not resolved upstream, according to the URL it's still "open".
Kindly asking to review the patches for the ebuilds..