Created attachment 343752 [details] buildlog without modemmanager gnome-base/gnome-control-center-3.8.0 should not depend on >=net-misc/networkmanager-0.9.8[modemmanager] (only on >=net-misc/networkmanager-0.9.8) see https://git.gnome.org/browse/gnome-control-center/commit/?h=gnome-3-8&id=4ef8ae4017a6a2bebf0b83da99dcaf0dad7d6fc0 above commit was reverted in master, you may want to keep the modemmanager dependency in the live ebuild. buildlog diff: @@ -294,7 +293,8 @@ checking for REMOTE_LOGIN_HELPER... yes checking for GVC... yes checking for NETWORK_MANAGER... yes -checking for MM_GLIB... yes +checking for MM_GLIB... no +configure: WARNING: *** Network panel will not be built with ModemManager1 support (libmm-glib not found) *** checking for BLUETOOTH... yes checking for SMBCLIENT... no configure: WARNING: *** Printer panel will not be built (smbclient.pc not found) *** @@ -420,7 +420,7 @@ config.status: executing po/stamp-it commands configure: gnome-control-center was configured with the following options: configure: ** NetworkManager (Network panel) -configure: ** ModemManager1 support (Network panel) +configure: ModemManager1 support disabled configure: Bluetooth panel disabled configure: ** colord (Color panel) configure: Printers panel disabled Portage 2.2.0_alpha170 (default/linux/amd64/13.0/desktop/gnome, gcc-4.7.2, glibc-2.15-r3, 3.8.4-gentoo x86_64) ================================================================= System uname: Linux-3.8.4-gentoo-x86_64-Intel-R-_Core-TM-_i7_CPU_M_620_@_2.67GHz-with-gentoo-2.1 KiB Mem: 8091200 total, 4640324 free KiB Swap: 8912892 total, 8912892 free Timestamp of tree: Sat, 30 Mar 2013 08:15:01 +0000 ld GNU ld (GNU Binutils) 2.22 app-shells/bash: 4.2_p37 dev-java/java-config: 2.1.12-r1 dev-lang/python: 2.7.3-r3, 3.2.3-r2 dev-util/cmake: 2.8.9 dev-util/pkgconfig: 0.28 sys-apps/baselayout: 2.1-r1 sys-apps/openrc: 0.11.8 sys-apps/sandbox: 2.5 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6 sys-devel/binutils: 2.22-r1 sys-devel/gcc: 4.6.3, 4.7.2-r1 sys-devel/gcc-config: 1.7.3 sys-devel/libtool: 2.4-r1 sys-devel/make: 3.82-r4 sys-kernel/linux-headers: 3.7 (virtual/os-headers) sys-libs/glibc: 2.15-r3 Repositories: gentoo poncho torbrowser infinality Installed sets: @kernels ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA AdobeFlash-11.x googleearth Nero-EULA-US Oracle-BCLA-JavaSE CAPYBARA-EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/firefox/searchplugins/google.xml /usr/share/eselect-lcdfilter/env.d/custom /usr/share/gnome-shell/theme/gnome-shell.css /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /usr/share/themes/Adwaita/backgrounds/adwaita-timed.xml /usr/share/thumbnailers/ffmpegthumbnailer.thumbnailer" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/var/portage/distfiles" EMERGE_DEFAULT_OPTS="--with-bdeps=y --ask --verbose --jobs=5 --load-average=6" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://mirror.switch.ch/ftp/mirror/gentoo http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo http://distfiles.gentoo.org" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j5 -l6" PKGDIR="/var/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_EXTRA_OPTS="--exclude=/lost+found --exclude=/metadata/cache/*" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp/portage-tmpfs" PORTDIR="/var/portage/tree" PORTDIR_OVERLAY="/var/portage/local/poncho-overlay /var/portage/local/torbrowser-overlay /var/portage/local/infinality-overlay" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="X a52 aac acl acpi alac alsa amd64 bash-completion berkdb bluetooth bluray bzip2 cairo cdda cdio cdr cdrdao cli colord consolekit cracklib crypt css cue cups cxx dbus device-mapper dirac dri dts dvd dvdr emboss encode evo exif faac fam ffmpeg firefox flac fontconfig fortran g3dvl gif gnome gnome-keyring gpm gstreamer gtk gtk3 iconv id3tag ipv6 jpeg kate lame lcms libass libnotify libsecret libtiger mad matroska mmx mmxext mng modules mp3 mp4 mpeg mudflap multilib nautilus ncurses networkmanager nls nptl nss nvidia ogg opencl opengl openmp opus pam pango pcre pdf png policykit postscript ppds pulseaudio qt3support quicktime readline rtmp schroedinger sdl session sndfile speex spell sse sse2 sse3 ssl ssse3 startup-notification svg tcpd theora threads thunderbird tiff truetype udev udisks unicode upower usb v4l vaapi vdpau vim-syntax vorbis vpx wav wavpack webp wxwidgets x264 xcb xinerama xml xv xvid xvmc zlib zsh-completion" ABI_X86="64" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev synaptics arvo" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby19" USERLAND="GNU" VIDEO_CARDS="nvidia vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON
I would keep it as-is because, from commit looks like they made modem-manager support automagic and, also, finally there were a networkmanager release with modem-manager-1 support
(In reply to comment #1) > I would keep it as-is because, from commit looks like they made > modem-manager support automagic and, also, finally there were a > networkmanager release with modem-manager-1 support For that reason I think would be better to keep this as-is
Surely this should have a match USE flags dependency (something like [?modemmanager]) rather than a hard requirement? Recent portage versions should suggest a change/block when the USE flags don't match, so the user's alerted to the problem and can add it to one or remove it from the other. Otherwise I thought general policy was to work with upstream to produce a patch that un-automagics the dependency rather than just marking as won't fix. I'm going to reopen this so that it doesn't get forgotten. If the decision really is to leave it as automagic without filing an upstream bug, then I won't reopen it again. I'd just like confirmation of that decision...
Well, you are true. The idea was to leave it as-is because upstream would drop the optional patch again once modemmanager-0.8 was released but, as looks it won't be released soon enough, the automagic would need to be solved (but I am not sure if upstream will want to do that as this optional feature is only temporal)
upstream has released 3.8.1.5 with an automatic dependency check on modemmanager I have tested the new version which build and runs good without modemmanager. ebuild is attached.
Created attachment 348002 [details] new bumped ebuild with a dropped build-in dependency on modemmanager
# Check for libmm-glib for ModemManager1 support PKG_CHECK_MODULES(MM_GLIB, mm-glib, [have_libmm_glib=yes], have_libmm_glib=no) if test "x$have_libmm_glib" = xno ; then AC_MSG_WARN(*** Network panel will not be built with ModemManager1 support (libmm-glib not found) ***) else AC_DEFINE(HAVE_MM_GLIB, 1, [Defined if libmm-glib is available]) fi AM_CONDITIONAL(HAVE_MM_GLIB, test "x$have_libmm_glib" = "xyes") -> It still looks automagic, I mean, when modemmanager is present, people will get its support enabled and they cannot disabled it, while, if it's not present at build time, it will get disabled: http://www.gentoo.org/proj/en/qa/automagic.xml
Created attachment 348010 [details, diff] patch to make modemmanager optional
please review this patch I have written it by hand))) seems to work for me)))
Created attachment 348012 [details] modified gnome-control-center-3.8.1.5.ebuild
(In reply to comment #10) > Created attachment 348012 [details] > modified gnome-control-center-3.8.1.5.ebuild oops forgot to add $(use_enable modemmanager)
Created attachment 348016 [details] new bumped ebuild with a dropped build-in dependency on modemmanager
+*gnome-control-center-3.8.1.5 (12 May 2013) + + 12 May 2013; Pacho Ramos <pacho@gentoo.org> + +files/gnome-control-center-3.8.1.5-optional-modemmanager.patch, + +gnome-control-center-3.8.1.5.ebuild, metadata.xml: + Version bump, prevent false positives with configure options checking, make + modemmanager optional (#463852 by Evgeny Bobkin and poncho), smbclient needed + for printers panel (#463762), fix bash-completion dir to Gentoo path (#465094 + by poncho). +
