Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 463750 - media-libs/alsa-lib - add multilib ABIs support
Summary: media-libs/alsa-lib - add multilib ABIs support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo ALSA team
URL:
Whiteboard:
Keywords: EBUILD, PMASKED
Depends on:
Blocks: gx86-multilib 463360 466608
  Show dependency tree
 
Reported: 2013-03-29 16:27 UTC by Karl Lindén
Modified: 2013-05-03 15:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for the ebuild (alsa-lib-1.0.26-r2.ebuild.patch,2.62 KB, patch)
2013-03-29 16:27 UTC, Karl Lindén
Details | Diff
A new ebuild with a conditional block. (alsa-lib-1.0.26-r2.ebuild,1.86 KB, text/plain)
2013-04-03 21:47 UTC, Karl Lindén
Details
An improved ebuild (alsa-lib-1.0.26-r2.ebuild,1.84 KB, text/plain)
2013-04-07 18:59 UTC, Karl Lindén
Details
Proper ebuild with multilib-minimal (alsa-lib-1.0.27-r1.ebuild,2.02 KB, text/plain)
2013-05-01 18:57 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Lindén 2013-03-29 16:27:29 UTC
Created attachment 343664 [details, diff]
Patch for the ebuild

I think media-libs/alsa-lib should have support for multilib ABIs so it can be dropped from app-emulation/emul-linux-x86-soundlibs.

I'm attaching a patch for the current one. The patch is working for me. I have tried the python and doc use flags and it should work.

Worth noticing is that python is hard disabled for all but the preferred ABI. It seems like it wont compile on anything but the best ABI. I have not looked into what impact it might have but not too much I hope.
Comment 1 Karl Lindén 2013-04-03 21:47:43 UTC
Created attachment 344300 [details]
A new ebuild with a conditional block.

Ooops, the block on app-emulation/emul-linux-x86-soundlibs must be conditional. This time Ḯ'm submitting the entire ebuild instead of a patch.
Comment 2 Karl Lindén 2013-04-07 18:59:11 UTC
Created attachment 344744 [details]
An improved ebuild

Remove redundant DOC variable, use run_in_build_dir and myconfargs is an array.

Difference from the previous one:

@@ -23,7 +23,6 @@
 	>=media-sound/alsa-headers-1.0.25
 	doc? ( >=app-doc/doxygen-1.2.6 )"
 
-DOCS=( ChangeLog TODO )
 PATCHES=( "${FILESDIR}/1.0.25-extraneous-cflags.diff" )
 
 AUTOTOOLS_AUTORECONF="1"
@@ -47,7 +46,7 @@
 		$(use_with debug)
 		$(use_enable alisp)
 	)
-	use elibc_uclibc && myeconfargs+=" --without-versioned"
+	use elibc_uclibc && myeconfargs+=( --without-versioned )
 
 	# Only enable python for the most preferred ABI
 	is_final_abi && myeconfargs+=( $(use_enable python) )
@@ -57,7 +56,6 @@
 }
 
 src_compile_doc() {
-	cd "${BUILD_DIR}"
 	if use doc; then
 		emake doc
 		fgrep -Zrl "${BUILD_DIR}" "${BUILD_DIR}/doc/doxygen/html" | \
@@ -67,7 +65,7 @@
 
 multilib_src_compile() {
 	autotools-utils_src_compile
-	is_final_abi && src_compile_doc
+	is_final_abi && run_in_build_dir src_compile_doc
 }
 
 multilib_src_install() {
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-05-01 13:36:23 UTC
(In reply to comment #2)
> @@ -23,7 +23,6 @@
>  	>=media-sound/alsa-headers-1.0.25
>  	doc? ( >=app-doc/doxygen-1.2.6 )"
>  
> -DOCS=( ChangeLog TODO )

If someone has taken the effort of going through the default documents and made and explicit list of them, they should be left alone. Otherwise you risk installing outdated documentation files the maintainer has decided are useless, for example. It other words, implicit DOCS blows.

Futhermore you should provide updated patch against alsa-lib-1.0.27.ebuild (notice how the usage of base.eclass is dropped, for example)

Thanks
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-01 18:57:06 UTC
Created attachment 347060 [details]
Proper ebuild with multilib-minimal
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-03 15:06:00 UTC
Committed as -1.0.27-r3, p.masked.