Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 463674 - app-text/gtkspell-3.0.0 fails to build. patch included
Summary: app-text/gtkspell-3.0.0 fails to build. patch included
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 06:15 UTC by Nick Novikov
Modified: 2013-04-02 13:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for gtkspell/Makefile.in (gtkspell-3.0.0-cflags.patch,887 bytes, text/plain)
2013-03-29 06:15 UTC, Nick Novikov
Details
gtkspell-3.0.2.ebuild (gtkspell-3.0.2.ebuild,1.14 KB, text/plain)
2013-03-29 11:45 UTC, Pacho Ramos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Novikov 2013-03-29 06:15:29 UTC
Created attachment 343584 [details]
patch for gtkspell/Makefile.in

/usr/bin/g-ir-scanner   --namespace=GtkSpell --nsversion=3.0 --libtool="/bin/sh ../libtool"  --include=GObject-2.0 --include=GLib-2.0 --include=Gtk-3.0   --library=libgtkspell3-3.la  --cflags-begin --warn-all @GTK_SPELL_CFLAGS@ --cflags-end  gtkspell.c gtkspell.h libgtkspell3-3.la --output GtkSpell-3.0.gir
gcc: error: @GTK_SPELL_CFLAGS@: No such file or directory
Error while processing the source.
make[2]: *** [GtkSpell-3.0.gir] Error 1
Comment 1 Pacho Ramos gentoo-dev 2013-03-29 11:45:47 UTC
Created attachment 343630 [details]
gtkspell-3.0.2.ebuild

I have tried to update it but still fails. Also looks like other distributions are not needing this patch... not sure if we are making some kind of hack that is causing this breakage

@gnome, any idea?
Comment 2 Rafał Mużyło 2013-03-30 00:13:15 UTC
Well, the question is whether other distributions use gtk3 or build it against gtk2.

But the typo in gtkspell/Makefile.am is a valid upstream bug.
Comment 3 Michael Hampicke 2013-04-02 07:42:08 UTC
The patch from comment #1 solved the issue here.
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-04-02 12:55:07 UTC
Interesting, this typo doesn't cause a failure or even any warning when using gobject-introspection-1.34, and I suppose this is why we hadn't noticed it before.
Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-04-02 13:56:20 UTC
Fixed, thanks. Modified patch (we want to patch Makefile.am, not Mafile.in) submitted upstream at https://sourceforge.net/p/gtkspell/bugs/17/

+  02 Apr 2013; Alexandre Rostovtsev <tetromino@gentoo.org>
+  gtkspell-3.0.0.ebuild, +files/gtkspell-3.0.2-GTK_SPELL_CFLAGS.patch:
+  Fix "@GTK_SPELL_CFLAGS@: No such file or directory" build failure (bug
+  #463674, thanks to Nick Novikov).