Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 462640 - app-admin/puppet-3.1: reload action on init script broken
Summary: app-admin/puppet-3.1: reload action on init script broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sysadmin Bugs
URL: https://projects.puppetlabs.com/issue...
Whiteboard:
Keywords:
: 466286 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-03-22 00:30 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2013-04-18 22:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2013-03-22 00:30:53 UTC
The reload action sends a SIGHUP to the puppet master process, which is running as user puppet (privileges are dropped within puppet's own code), but was started as user root.

In /usr/lib64/ruby/site_ruby/1.9.1/puppet/util/run_mode.rb (or equivalent path of course), the directory to look data in depends on the user that the process is started from: if root, it searches /var/lib/puppet, otherwise it searches ~/.puppet.

What happens at this point is that the process is being executed as user puppet but still has HOME set to "/root", so puppet goes to search for the data in /root/.puppet — which it obviously can't access without root privileges, and thus will fail.

We should remove reload() until this is fixed, probably upstream.
Comment 1 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-03-22 04:33:14 UTC
I think that's fine to remove til it's fixed for 3.1
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2013-03-22 13:25:05 UTC
Three in agreement (Theo said that he would do the same but didn't want to take the decision), so removed in 3.1.1-r1.

I'll keep you guys posted about the upstream issue.
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-03-22 13:31:20 UTC
I'd like to keep this bug open til it's fixed (I know you said you'd keep us posted).
Comment 4 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2013-03-22 13:35:05 UTC
imho this bug should close since it is fixed given the current situation of the upstream package. if you are interested about any updates in the upstream bug you can add yourself there as a watcher (but again, I'm not willing to take the decision). Thanks for the investigation and the fix btw
Comment 5 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-03-22 14:21:20 UTC
worksforme
Comment 6 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-04-18 22:22:46 UTC
*** Bug 466286 has been marked as a duplicate of this bug. ***