Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 462538 - <sys-fs/udev-198-r3 labels files in /dev incorrectly on boot
Summary: <sys-fs/udev-198-r3 labels files in /dev incorrectly on boot
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: SELinux (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: udev maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 00:15 UTC by Amadeusz Sławiński
Modified: 2013-03-21 23:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output of diff a b (aaaaaaa,15.37 KB, text/plain)
2013-03-21 00:16 UTC, Amadeusz Sławiński
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Sławiński 2013-03-21 00:15:17 UTC
As discussed on irc, udev 198 doesn't label files in /dev correctly, some of them have correct context while some do not.

ls -Z /dev > a
restorecon -R /dev
ls -Z /dev > b
diff a b

diff shows that a lot of files have wrong context


It seems to be caused by this commit:
http://cgit.freedesktop.org/systemd/systemd/commit/?id=22582bb2cbe85b40de5f561589e0468dac769515
in particular by two lines from it:
- if (strcmp(udev_device_get_action(dev), "add") == 0) {
+ if (apply) {

After replacing apply with strcmp, all files are labeled correctly again

apply is passed via function calls with initial call in src/udev/udev-event.c in function udev_event_execute_rules

udev_node_add(dev, event->owner_set || event->group_set || event->mode_set,
  event->mode, event->uid, event->gid);

event->owner_set || event->group_set || event->mode_set  evaluates to value of apply

"udev_node_add" then calls passing apply "node_permissions_apply" which has "if (apply) {" check

Reproducible: Always




Portage 2.1.11.55 (hardened/linux/13.0/amd64/selinux, gcc-4.7.2, glibc-2.16.0, 3.8.3-hardened x86_64)
=================================================================
System uname: Linux-3.8.3-hardened-x86_64-Intel-R-_Core-TM-_i3_CPU_M_350_@_2.27GHz-with-gentoo-2.2
KiB Mem:     2997032 total,   2179792 free
KiB Swap:    3145724 total,   3145724 free
Timestamp of tree: Tue, 19 Mar 2013 00:00:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r1
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.13.1
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.7.2-r1
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.8 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo x11 hardened-dev my_local_overlay
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-11.x PUEL skype-4.0.0.7-copyright google-talkplugin"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -march=native -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O3 -march=native -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox selinux sesandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/x11 /var/lib/layman/hardened-development /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acpi alsa amd64 bash-completion berkdb bzip2 cli cracklib crypt cups cxx dbus dri dvd gdbm gif gpm hardened iconv icu ipv6 jpeg jpeg2k justify libnotify mmx mng modules mp3 mudflap multilib ncurses nls nptl open_perms opengl openmp pam pax_kernel pcre png readline selinux session sse sse2 sse4_1 sse4_2 ssl ssse3 tcpd threads tiff udev unicode urandom usb v4l vaapi vdpau vim-syntax vlc wacom xattr xft xinerama zlib zsh-completion" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB pl" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" QEMU_SOFTMMU_TARGETS="x86_64 ppc" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Amadeusz Sławiński 2013-03-21 00:16:04 UTC
Created attachment 342794 [details]
output of diff a b
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2013-03-21 20:27:51 UTC
198-r2 was committed meanwhile with,

http://cgit.freedesktop.org/systemd/systemd/commit/?id=bbb7f2ae5035105575365750592caa87213d7072

that is likely related to your problem with 198-r1 too, -r2 was committed since USB printers (GROUP="lp") and usb_id stuff was in wrong order, and others were too
in any case, update the bug with 198-r2 as test base
Comment 3 Amadeusz Sławiński 2013-03-21 21:14:25 UTC
It still doesn't work

[ebuild   R    ] sys-fs/udev-198-r2  USE="gudev hwdb kmod openrc (selinux) static-libs -acl -doc -introspection -keymap" 0 kB
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-03-21 21:18:43 UTC
Thanks. 
You seem to describe it well in Comment #0, would you mind opening a bug at http://bugs.freedesktop.org/ against the "systemd" component?
Comment 5 Amadeusz Sławiński 2013-03-21 21:31:03 UTC
Here it is:
https://bugs.freedesktop.org/show_bug.cgi?id=62615
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2013-03-21 21:36:31 UTC
Asked around and udev upstream told me there are known problems with selinux, based on his information I've opened bug 462626
And was also informed you should contact Daniel Walsh (dwalsh), The Fedora selinux maintainer who does all the work for selinux on udev
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2013-03-21 23:03:02 UTC
Nice work.

Upstream patch in portage.

http://cgit.freedesktop.org/systemd/systemd/patch/?id=9a8ae49d91ae303c4f7c87f9c56fba3e8d646af7

+*udev-198-r3 (21 Mar 2013)
+
+  21 Mar 2013; Samuli Suominen <ssuominen@gentoo.org> +udev-198-r3.ebuild:
+  Upstream patch for always setting selinux labels at "add" events wrt #462538
+  by Amadeusz Sławiński