Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 461688 - =gnome-base/gdm-3.6.2: superflous ConsoleKit (and systemd?) pam module deps
Summary: =gnome-base/gdm-3.6.2: superflous ConsoleKit (and systemd?) pam module deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 03:19 UTC by Samuli Suominen (RETIRED)
Modified: 2013-03-14 04:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Drop superflous pam_ck_connector.so dependency (gdm-3.6.2.ebuild.patch,467 bytes, patch)
2013-03-14 03:19 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2013-03-14 03:19:38 UTC
Created attachment 341978 [details, diff]
Drop superflous pam_ck_connector.so dependency

Display managers with internal ConsoleKit support don't need the pam_ck_connector.so pam module that gets installed by sys-auth/consolekit[pam], and as a result, they don't require sys-auth/pambase[consolekit] either since it would just add a line to pam.d about pam_ck_connector.so

The same logic propably applies to systemd-logind as well

The attached patch relaxes the deps
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-03-14 03:34:14 UTC
(In reply to comment #0)
> Display managers with internal ConsoleKit support

Please explain what this "internal ConsoleKit support" means and where gdm has it. For example, if you are talking about ck_connector_open_session(), gdm-3.6.x does not call it.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2013-03-14 03:56:54 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Display managers with internal ConsoleKit support
> 
> Please explain what this "internal ConsoleKit support" means and where gdm
> has it. For example, if you are talking about ck_connector_open_session(),
> gdm-3.6.x does not call it.

GDM talks to ConsoleKit using DBUS and gets the required information that way, "grep -r org.freedesktop.ConsoleKit *" in gdm source tree
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-03-14 03:58:27 UTC
If pam_ck_connector.so was used, then "ck-list-sessions" would list 2 sessions, but it doesn't, there is only 1, started via dbus by the DM

(When you startx with ck-launch-session, then you see 2 and the module is used)
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-03-14 04:01:30 UTC
(In reply to comment #3)
> If pam_ck_connector.so was used, then "ck-list-sessions" would list 2
> sessions, but it doesn't, there is only 1, started via dbus by the DM
> 
> (When you startx with ck-launch-session, then you see 2 and the module is
> used)

As in, the "nox11" in /etc/pam.d for pam_ck_connector.so prevents it being 'executed' with display managers...
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2013-03-14 04:02:44 UTC
And some arch's like MIPS don't have AUDITSYSCALL=y support in kernel, which is mandatory for the pam module, thus if they want working CK session, they must use display manager
So this is not only cosmetics
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2013-03-14 04:04:05 UTC
This is actually a regression in 3.6.2's ebuild:

  11 Nov 2010; Samuli Suominen <ssuominen@gentoo.org> gdm-2.20.10-r2.ebuild,
  gdm-2.20.11.ebuild, gdm-2.28.2-r1.ebuild, gdm-2.32.0.ebuild:
  Remove false PDEPEND on pambase wrt #344989: GDM doesn't use
  pam_ck_connector.so and works without.
Comment 7 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-03-14 04:32:58 UTC
(In reply to comment #4)
> As in, the "nox11" in /etc/pam.d for pam_ck_connector.so prevents it being
> 'executed' with display managers...

Thanks, that is a very good point :)

Fixed both in gx86 and gnome overlay. (For pam[-systemd], I would prefer someone who understands and runs systemd to really test it, because gdm+systemd interaction is notoriously fragile.)