Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 461638 - www-servers/varnish-3.0.3 - automagical dependency on dev-libs/jemalloc
Summary: www-servers/varnish-3.0.3 - automagical dependency on dev-libs/jemalloc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 14:23 UTC by Ștefan Talpalaru
Modified: 2013-03-19 22:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ștefan Talpalaru 2013-03-13 14:23:55 UTC
varnish is compiled against jemalloc by default on Linux so we need a dependency added in the ebuild. Bonus points for disabling the magic and adding a "jemalloc" USE flag enabled by default.

Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2013-03-14 15:52:06 UTC
It was worse than just an automagic dependency, they were bundling libjemalloc.  I've completely removed that and added USE=jemalloc.

Please test varnish-3.0.3-r1 and reopen this bug if there is still a problem with jemalloc.  Open a different bug for a different issue.  I'd like to try to get this stabilized in about a month.
Comment 2 Ștefan Talpalaru 2013-03-17 19:51:12 UTC
The compilation against jemalloc-3.3.0 fails because of the varnish-3.0.3-automagic.patch that makes configure look for an inexistent "jmalloc_conf" instead of the original "malloc_conf".
Comment 3 Anthony Basile gentoo-dev 2013-03-18 12:20:41 UTC
(In reply to comment #2)
> The compilation against jemalloc-3.3.0 fails because of the
> varnish-3.0.3-automagic.patch that makes configure look for an inexistent
> "jmalloc_conf" instead of the original "malloc_conf".

Okay this patch needs more work.  With jemalloc-2.2.5 we have

# readelf -sW /usr/lib64/libjemalloc.so.1 | grep malloc_conf
47: 000000000021b1a8     8 OBJECT  GLOBAL DEFAULT   24 jmalloc_conf

while with jemalloc-3.3.0 we have

# readelf -sW /usr/lib64/libjemalloc.so.1 | grep malloc_conf
66: 0000000000241608     8 OBJECT  GLOBAL DEFAULT   26 malloc_conf

The annoying thing here is that they didn't do a version bump on the library even though the API changed, both jemalloc-2 and -3 have /usr/lib64/libjemalloc.so.1.

Give me a bit, I'll fix.
Comment 4 Anthony Basile gentoo-dev 2013-03-19 22:24:26 UTC
Okay I now have it checking first for malloc_conf and failing that, checking for jmalloc_conf.  I tested against both jemalloc-2 and jemalloc-3 and it builds.  I'm not running it, so I don't know if it works at runtime.

Thanks for the report!  This was an important bug to squash.  Feel free to open this if there's still an issue with jemalloc.