Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 460732 - media-gfx/photivo-9999: Fix sed pattern
Summary: media-gfx/photivo-9999: Fix sed pattern
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest normal (vote)
Assignee: Marios Andreopoulos
URL:
Whiteboard:
Keywords: InVCS, PATCH, REVIEWED
Depends on:
Blocks:
 
Reported: 2013-03-07 22:35 UTC by Alexander Stein
Modified: 2013-03-13 19:17 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch fixing the build failure about using pkgconfig for CImg (photivo.patch,704 bytes, patch)
2013-03-07 22:35 UTC, Alexander Stein 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Stein 2013-03-07 22:35:09 UTC 
In upstream commit df8950c8f85e the file photivoProject/photivoProject.pro got changed considerably. It changed the line "PKGCONFIG  += CImg" to "PKGCONFIG += CImg" (notice the missing space character).
This causes the following compiler error:
make[1]: Leaving directory `/tmp/portage/media-gfx/photivo-9999/work/photivo-9999/ptClearProject'
cd photivoProject/ && /usr/bin/qmake /tmp/portage/media-gfx/photivo-9999/work/photivo-9999/photivoProject/photivoProject.pro QTDIR=/usr/lib64 QMAKE=/usr/bin/qmake QMAKE_AR=x86_64-pc-linux-gnu-ar\ cqs QMAKE_CC=x86_64-pc-linux-gnu-gcc QMAKE_CXX=x86_64-pc-linux-gnu-g++ QMAKE_LINK=x86_64-pc-linux-gnu-g++ QMAKE_LINK_C=x86_64-pc-linux-gnu-gcc QMAKE_OBJCOPY=x86_64-pc-linux-gnu-objcopy QMAKE_RANLIB= QMAKE_STRIP= QMAKE_CFLAGS=-O2\ -march=native\ -pipe QMAKE_CFLAGS_RELEASE= QMAKE_CFLAGS_DEBUG= QMAKE_CXXFLAGS=-O2\ -march=native\ -pipe QMAKE_CXXFLAGS_RELEASE= QMAKE_CXXFLAGS_DEBUG= QMAKE_LFLAGS=-Wl,-O1\ -Wl,--as-needed\ -Wl,-z,now\ -Wl,--sort-common QMAKE_LFLAGS_RELEASE= QMAKE_LFLAGS_DEBUG= QMAKE_LIBDIR_QT=/usr/lib64/qt4 QMAKE_LIBDIR_X11=/usr/lib64 QMAKE_LIBDIR_OPENGL=/usr/lib64 CONFIG+=WithSystemCImg\ WithGimp -o Makefile
Project MESSAGE: Building Photivo 2013-03-07 (rev eb63cc79248b)+
Using system supplied CImg library
Project ERROR: Package CImg not found
make: *** [photivoProject/Makefile] Error 2

I will attach a patch to fix that.

Reproducible: Always

Steps to Reproduce:
1. emerge =photivo-9999
Comment 1 Alexander Stein 2013-03-07 22:35:53 UTC 
Created attachment 341268 [details, diff]
patch fixing the build failure about using pkgconfig for CImg
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2013-03-08 22:56:08 UTC 
It is a live ebuild so breakages are expected. Thanks for the patch
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2013-03-10 21:26:22 UTC 
Marios, are you happy with the patch?
Comment 4 Marios Andreopoulos 2013-03-11 02:03:34 UTC 
Yes! The patch works as expected. Thanks once more Alexander.

I use the testing version these days, so such bugs may escape my attention. :)
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2013-03-13 19:17:50 UTC 
+  13 Mar 2013; Markos Chandras <hwoarang@gentoo.org> photivo-9999.ebuild:
+  Fix sed pattern. Thanks to Alexander Stein <alexander.stein@informatik.tu-
+  chemnitz.de>. Bug #460732
+